🇦🇺Australia @bradtreloar

It should be implicit that any tag used in Styles be allowed by the HTML filter. The Style plugin just isn't telling the validator which tags it creates.

In this case, Style::getElementsSubset returns these elements:

<span class="text-large">
<span class="text-primary">
<span class="text-secondary">

None of these are considered createable because they all have attributes.

The plain (creatable) element is missing, i.e.

<span>

To fix this, Style::getElementsSubset could add a plain element for each tag used in the styles list.

e.g.

  public function getElementsSubset(): array {
    $elements = array_column($this->configuration['styles'], 'element');

    // Add a creatable element for each tag used in styles.
    $ghs_config = HTMLRestrictions::fromString(implode($elements))->toGeneralHtmlSupportConfig();
    $tags = array_column($ghs_config, 'name');
    foreach ($tags as $tag) {
      $elements[] = "<{$tag}>";
    }

    return $elements;
  }

The tags and classes used in all of the styles are automatically added to/removed from the HTML filter's list of allowed HTML tags as the list of styles is updated by the user.

bradtreloar → made their first commit to this issue’s fork.

The NullPointerException is thrown because Solr is trying to get the unique key from the list of fields returned by the query.

The default uniqueKey field is id. Adding it to the field list fixes the error.

// Add the documents ids to be elevated to the search query.
if (isset($query_item_ids['elevate']) && is_array($query_item_ids['elevate'])) {
  $query->setOption('solr_param_elevateIds', implode(',', $query_item_ids['elevate']));
  $query->setOption('solr_param_fl', 'id,[elevated]');
}

bradtreloar → made their first commit to this issue’s fork.