The patch #3 doesn't apply to 4.0.0 release.
Drupal upgrade status yields this error:
Call to deprecated method getImplementations() of class
Drupal\Core\Extension\ModuleHandlerInterface. Deprecated in
drupal:9.4.0 and is removed from drupal:10.0.0. Instead you
should use ModuleHandlerInterface::invokeAllWith() for hook
invocations or you should use
ModuleHandlerInterface::hasImplementations() to determine if
hooks implementations exist.
Checking with upgrade status, gives this error:
The 'basic_cart' library is depending on a deprecated
library. The "core/jquery.ui" asset library is deprecated in
drupal:9.2.0 and is removed from drupal:10.0.0. See
https://www.drupal.org/node/3067969 →
Tested patch #75. With this new behavior when code is sent only after clicking "Send" button, the hint text under the code box
"The authentication code has been sent to your registered email. Check your email and enter the code."
is not correct anymore, since the code is not being sent initially.
I would suggest to change it to Status message area instead of embedded in the form as of now. Attaching a patch with this change.
The patch from the issue RfcComplianceException: RFC 2822 🐛 RfcComplianceException: RFC 2822 Needs work sets Return-Path correctly.
@keshav.k,
As mentioned earlier, just setting it to an empty array instead of NULL, causes the empty block to show on the page. The block is still rendered as empty. Just reverting the commit back doesn't fix the issue.
@mihaic,
Thanks for the info. The patch in #3 doesn't work fully, since the language switcher block becomes visible when the value is set to an empty array [].
l-laziz → created an issue.
The changes in this commit cause PHP fatal error with Core update 9.5.9 because it expects an array value, however NULL is given.
This looks like the change (git diff) from the merged commit causing error:
- $links = [];
+ $links = $config->get('hide_single_link_block') ? NULL : [];
The Core 9.5.9 doesn't accept NULL value anymore.
The changes in this commit, cause PHP fatal error wit hCOre update 9.5.9 because it expects an array value, however NULL is given.
This looks like the change (git diff) from the merged commit causing error:
- $links = [];
+ $links = $config->get('hide_single_link_block') ? NULL : [];
@simon-p,
FYI: This feature has been already addressed/implemented here:
issue 3240363
✨
Module to provide configurable mail body and subject content for reset and pending password emails.
RTBC
The patch #39 implementing customizable title/body form applies cleanly to 4.0.0 module version upon testing.
The feature/issue is still relevant for 4.x version and the patch #39 applies to 4.0.0 module version cleanly.