Hi,
Sorry for the delay, I know people have been waiting for it. I didn't have much time to work on the subject.
But I did try to follow along the conversation. At first, I didn't understand why people worked on this version as CKEditor 4 support stopped at the same time as Drupal 9. But I discovered in the conversation that having a D10/CK4 version ease the transition of some project to Drupal 10.
I am not sure if the ThemeExtensionList service is the good one to use as it is marked @internal in the documentation and therefore should not be used as a public api if I read it correctly. But that can be corrected later in another issue if needed.
Thanks everyone who participated.
I'll look at the CKEditor 5 issue very soon to have another release.
Sorry again for the delay.
Thank you @mhespanhol for all the work.
I understand alternatives are not ideal for everyone and some contrib prefer flexibility over maintenance (which is always relative on depends on each website context).
So let's upgrade this module !
I updated the project page to explain the current Drupal 10 situation, created a 2.x branch and set it as target for the merge request.
Now, we need to test and review this new version.
I only had a quick look but I have two comments for now :
- is the licence file required ? All modules hosted on Drupal.org have to follow Drupal licence + the licence file is automatically generated and added when downloading the module or installing via composer.
- is using webpack and yarn required to develop the CKEditor plugin ? It adds quite a lot of complexity for such a simple need.
I even asked myselft if the CKEditor plugin should be deliver with this module or hosted on CKeditor platform ? For sure, it is easier to install when bundle together but could it be of any use for people using CKeditor outside of Drupal, who were using the Template plugin ?