Thanks for the fix! Release dev-1.0.x now works great on D9.
Thanks for posting those updates @nk_! There's a chance the update to dev-1.0.x introduced an incompatibility with D9. Here's the error I'm seeing now, when trying to run update.php:
Error: Class "Drupal\Core\Render\Element\FormElementBase" not found in D:\Development\drupal-b\modules\contrib\swiper_formatter\src\Element\SwiperFormatterSettings.php
I see that FormElementBase will be removed from D12 and begin deprecation in D10, but I wouldn't have thought it would be an issue for D9: RenderElement and FormElement base plugin classes are deprecated and renamed to RenderElementBase and FormElementBase β .
ryankavalsky β created an issue.
Thank you! I'll give this a try the next chance I get.
ryankavalsky β created an issue.
That's a great question, sorry for not including this info in the issue summary. I'm on 9.5.11, but that's even "protected" in that version of Drupal Core. Even more strangely, I didn't get this error in one of our lower environments, even though all environments are running the same Drupal version.
For me, something must have gotten knocked off kilter in my PROD environment, which has renderFields() defined as a "public" function in PROD, though it's clearly supposed to be "protected". Thanks for helping me troubleshoot!
ryankavalsky β created an issue.
I'm grateful to have found this thread. My notification emails stopped going out altogether ("Unable to send email. Contact the site administrator if the problem persists"), apparently because there was nobody in the "To" field. This approach fixed that issue! The current patches weren't applying to 8.x-3.5, so I re-rolled the patch for compatibility. Please wrap this patch into the next release of the module. Thank you!
Never mind - I've learned that the compact date formats I had set up must not have transferred when upgrading Drupal from 8 to 9, or perhaps when upgrading this module. After re-creating my default compact format, everything worked again.
Is there a solution for this issue, yet? I seem to have run into it myself with Drupal 9.5.11 and daterange_compact 2.0.1.
ryankavalsky β created an issue.