πŸ‡ΊπŸ‡ΈUnited States @wsantell

Account created on 8 August 2014, over 10 years ago
#

Merge Requests

Recent comments

πŸ‡ΊπŸ‡ΈUnited States wsantell

Running this module with the patch for 75f038cc causes this error:
PHP Fatal error: Type of Drupal\siteimprove\Form\SettingsForm::$typedConfigManager must not be defined (as in class Drupal\Core\Form\ConfigFormBase) in /var/www/html/docroot/modules/contrib/siteimprove/src/Form/SettingsForm.php on line 0

In short, $typedConfigManager is defined in ConfigFormBase and does not need to be replicated in the form which is extending it.

It doesn't look like I'm allowed to edit the SettingsForm file to make a new commit. Deleting these lines (76-82) in the patched file resolves the error:

  /**
   * Typed Config Service.
   *
   * @var \Drupal\Core\Config\TypedConfigManagerInterface
   */
  protected TypedConfigManagerInterface $typedConfigManager;

πŸ‡ΊπŸ‡ΈUnited States wsantell

I believe this issue is fixed in the 2.x branch. I had upgraded to 2.0.0 and when this patch applied it caused some issues I erroneously reported in issue 3460855.

πŸ‡ΊπŸ‡ΈUnited States wsantell

This is an invalid issue that stems from changing to the 2.x branch and applying a patch from issue 2949963 which added this code:

elseif ($entity && ($entity instanceof ContentEntityInterface) && !$entity->isNew()) {
      $entity_url = base_path() . $entity->toUrl('canonical', ['absolute' => TRUE])->getInternalPath();
      $system_config = \Drupal::configFactory()->get('system.site');

      if ($system_config->get('page.front') === $entity_url) {
        $metatags = $this->metatagDefaults->load('front');
      }
      elseif ($system_config->get('page.403') === $entity_url) {
        $metatags = $this->metatagDefaults->load('403');
      }
      elseif ($system_config->get('page.404') === $entity_url) {
        $metatags = $this->metatagDefaults->load('403');
      }
    }
πŸ‡ΊπŸ‡ΈUnited States wsantell

The patch for #81 fails due to Color being removed from Core β†’ . The attached patch is a rewrite of #81 with the color.module patch removed.

πŸ‡ΊπŸ‡ΈUnited States wsantell

To address the OP, this appears to be an issue with google/protobuf in cloud environments. This is the corresponding issue on their github: https://github.com/protocolbuffers/protobuf/issues/11203

Production build 0.71.5 2024