thomasdbcklr → created an issue.
Thomasdbcklr → changed the visibility of the branch 3425357 to active.
Thomasdbcklr → changed the visibility of the branch 3425357 to hidden.
Pushed a fix, things we could do better:
* I disabled the following component file // import '../../../../core/themes/classy/css/components/file.css'; // for file upload field
** Could just reference the contrib theme instead?
* Instead of disabling the ESlint in the webpack config make sure it works?
Thomasdbcklr → changed the visibility of the branch 3415469-fix-storybook-broken to active.
Thomasdbcklr → changed the visibility of the branch 3415469-fix-storybook-broken to hidden.
Thomasdbcklr → created an issue.
We are using the following which are deprecated functions in D10 and will not work
$theme_path = drupal_get_path('theme', 'rocketship_theme_starter');
$variables['title'] = render($variables['page']['#title']);
Would have liked to create a start point already but it seems the ['page']['#title'] has been changed as well and needs further looking into.
Had problems with this one while working on #3368324 📌 Replace Classy core theme by contrib theme Fixed
Our gulp tasks require certain .css files to exists mainly
'css:fonts',
'css:mail',
'css:editor'
When compiling you'll get the following error:
Error: File not found with singular glob: /rocketship_theme_starter/css/style.editor.css (if this was purposeful, use `allowEmpty` option)
We can either keep empty .css files or figure out how to change these tasks that they don't require the files to be present at first ( haven't looked into how we could do this )
Scope has changed to require the contrib theme instead, so we can potentially convert our generator to use the core Starterkit generator instead
- Bumped the generated theme .info file's core version to 9 || 10
- Added classy, components & unified_twig_ext in composer.json because we require their latest versions for D10
Thomasdbcklr → made their first commit to this issue’s fork.
Added the needed ckeditor5-stylesheets reference
Kept the old ckeditor_stylesheets as well for some backwards compatibility
Updated the ckeditor styles we have so they work for both 4 & 5 for the moment.
Added some basic font-family support for ckeditor 5 as well
Thomasdbcklr → made their first commit to this issue’s fork.