Hi GuyManDude, is it related to this issue? #2706421 - Markup rendering incorrectly with views fields →
Thanks Virendra. I created a new branch for the change earlier but forgot to open a Merge Request. I have opened one now, but it's the same as your patch, so probably best to let someone else review it in case I missed something when testing.
It sounds like you might be looking for a modal popup solution? Do you have some more details about what you mean about it working out of the box with forms?
Magnific Popup will work with images and videos, but doesn't support forms.
Thanks everyone for working on this issue. I have started a 2.x dev branch and merged this in.
Hi Parashram, video_embed_vidyard doesn't have a .module file in either version 1.0 or 2.0. Did you by chance have a patch applied that added one that you haven't yet reapplied after updating?
No worries, happens to all of us from time to time!
Hi Kcolwell,
At the moment version 8.x-1.1 and 2.0.0 are essentially the same, with the only difference (for now) being that 2.0.0 is marked as supporting Drupal 10. From memory there are no extra steps required for this module (should be backwards compatible) after upgrading from 8.0, however if you upgraded the parent module (video_embed_field) at the same time, you may need to run a database update and cache rebuild.
If that doesn't solve the issue, please add some more information about your setup and I'll try to help you debug this.
Committed to the 2.x branch.
Please see the existing issue here: https://www.drupal.org/project/magnific_popup/issues/3297563 📌 Automated Drupal 10 compatibility fixes RTBC
Committed. Thanks everyone!
Updated the patch to get tests passing and added a new test case.
No updates on this for a few years now so marking this as closed. Please feel free to re-open if someone needs this/wants to work on it.