🇳🇱Netherlands @Edwin Knol

Account created on 26 October 2013, about 11 years ago
#

Recent comments

🇳🇱Netherlands Edwin Knol

@mmbk I'm not able to find the time to create a test for the markup right now.

🇳🇱Netherlands Edwin Knol

Added Patch let me know what you think.

🇳🇱Netherlands Edwin Knol

@mmbk Thanks for your support at Drupal Europe.

What kind of test do you mean ?
User testing or automated test.
Should i be the one to put the issue on RTBC or should this be done by another Community user ?

🇳🇱Netherlands Edwin Knol

@mfairchild365 While reviewing the code i noticed the following function in form.inc.

if (isset($variables['element']['#type']) && $variables['element']['#type'] === 'radios') {
  unset($variables['attributes']['required']);
  unset($variables['attributes']['aria-required']);
  unset($variables['attributes']['aria-invalid']);
}

We could also choose to not set the attributes instead of unsetting them by overwriting setAttributes() in the class Radios.
I will try this to see if this could work and if so apply a patch.

🇳🇱Netherlands Edwin Knol

Reviewing from Drupal europe 2018 mentored by @mmbk

Production build 0.71.5 2024