Account created on 11 July 2013, almost 12 years ago
#

Merge Requests

Recent comments

🇷🇴Romania zoltanb

Hi

FYI with the patch applied on 1.30 release, i get

[warning] foreach() argument must be of type array|object, null given DefinitionDiscoveryFactory.php:73
 [success] Cache rebuild complete.

after rebuilding the cache.

🇷🇴Romania zoltanb

The fix looks mostly ok.

Some notes:

  1. The core/once library should be added as dependency in widget_engine.libraries.yml file.
  2. The once variable should be added as an argument to the respective JS files (like jQuery, Drupal, drupalSettings ...)

Thanks

🇷🇴Romania zoltanb

Now we have a similar issue due to the dependency logic changes in entity_browser v2.10:

The website encountered an unexpected error. Please try again later.
Error: Call to a member function getStorage() on null in Drupal\widget_engine_entity_form\Plugin\Field\FieldWidget\WidgetEngineEntityReferenceBrowserWidget->formElementEntities() (line 571 of modules/contrib/widget_engine/modules/widget_engine_entity_form/src/Plugin/Field/FieldWidget/WidgetEngineEntityReferenceBrowserWidget.php).

Checked on:
entity_browser: 2.10
widget_engine: 1.5

Projects extending the same class had this problem, like https://git.drupalcode.org/project/crop_image/-/commit/9e45ae6621bd45552...

I've attached a patch.

🇷🇴Romania zoltanb

Hi

I've created a MR with a full update of the module for OAth and Private App access token.

Compatibility:
- Drupal 10
- latest hubspot/api-client (v10)
- PHP 8.1

Some notes:
- tried to re-use as much code as possible
- re-used the access_key config (deprecated), to save there the new Private App access token (breaking change)
- added new public methods for getting the handler directly with OAuth or Private App access token
- fixed some minor bugs (undefined indexes, color for status was not working)

I think we should add this to a new version, like 3.0 alpha, because of the breaking changes.

🇷🇴Romania zoltanb

I'm working on a version for Drupal 10 + PHP 8.1 + latest hubspot-api-php. I need both of OAuth and Private App access token, so i will try to handle both cases and create a Merge Request next week.

🇷🇴Romania zoltanb

Hi

This library supports only legacy API
Please consider switching to the latest API.

https://github.com/HubSpot/hubspot-php is only for legacy now, i think we should focus on https://www.drupal.org/project/hubspot_api/issues/3334746 Switch to PHP HubSpot API v3 SDK Client Needs review and close this issue.

🇷🇴Romania zoltanb

Hi

After updating to Drupal core 9.5.9+ an issue appeared with Page Manager - "Path has unnecessary query appended." ( https://www.drupal.org/project/page_manager/issues/3362561 🐛 Path has unnecessary query appended. Fixed ). We applied the latest patch from there, but after that the body classes are not applying anymore to the pages.

I updated the patch #26 with slight changes:

  1. use key _page_manager_page_variant instead of page_manager_page_variant
  2. use \Drupal::request() instead of \Drupal::routeMatch() (because parameter is not available there anymore)

Now it is working again. See diffs in https://www.drupal.org/project/page_manager/issues/3362561 🐛 Path has unnecessary query appended. Fixed for more details.

🇷🇴Romania zoltanb

Hi

I just confirm that we have the same issue after updating to Drupal 9.4. We do not use this module, we can not see these statistics anymore in New Relic.
We have created a support ticket on their side, see more details there: https://forum.newrelic.com/s/hubtopic/aAX8W0000008druWAA/php-drupal-94-c...
Another one: https://forum.newrelic.com/s/hubtopic/aAX8W0000008ddmWAA/php-drupal-9-pr...

Production build 0.71.5 2024