πŸ‡ΊπŸ‡ΈUnited States @simplyshipley

Account created on 22 June 2013, almost 12 years ago
#

Recent comments

πŸ‡ΊπŸ‡ΈUnited States simplyshipley

Removed the patch file I uploaded to the wrong issue.

πŸ‡ΊπŸ‡ΈUnited States simplyshipley

simplyshipley β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States simplyshipley

Here's a patch that I recently created for a project that I updated from Facets 3.0beta1 to Facets 3.0. It works for my simple implementation of exposing a relative date filter with 3 options. It needs some work on the Ajax for the config form to get it to dynamically add new relative date field sets using the "Add more" functionality. I spent some time trying to figure it out, but I there's a core bug in views forms that use Ajax where the incorrect config form gets passed, so it's not a straightforward task. I'll find the views core issue and add a link shortly.

I ended up just adding a new number field to the form to store the number of relative date range options needed. You just set the count then save and reopen the form and that number of field sets are available. I intend to create a MR for this issue, but I've not had the time to do so.

πŸ‡ΊπŸ‡ΈUnited States simplyshipley

I created a couple patches to help resolve this issue:

linkchecker-add-remove-all-links-button-to-admin-settings-form-3386292-7.patch
Adds a button to the LinkCheckerAdminSettingsForm.php file that allows users to delete all link data by reusing an existing method
$this->linkCleanUp->removeAllBatch();

linkchecker-added-delete-operation-and-route-to-linkchecker-entity-3386292-7.patch
This patch adds a the delete operation to the custom entity. It adds the core\Entity\ContentEntityDeleteForm as the delete form and a matching delete link. I also mapped the "label" = "lid" so the link entity ids shows if using bulk operations. This patch also adds the new delete route to the LinkCheckerLinkRouteProvider.php.

These patches allow users to delete individual link entities and/or delete all link entities to uninstall the module.

πŸ‡ΊπŸ‡ΈUnited States simplyshipley

Patch #4 was failing to install with composer-patches so I applied the changes to the file and created this patch. I attempted to create an interdiff between the files, but interdiff created a blank file and gave this message "interdiff: Whitespace damage detected in input".

πŸ‡ΊπŸ‡ΈUnited States simplyshipley

I really like the idea of this module. and it seems to work well during my initial testing. But I'm not a fan of being forced to truncate production database tables to uninstall the module, so I will not be using it at this time. Are there plans to allow the linkchecker entities to be deleted through the UI in the future?

πŸ‡ΊπŸ‡ΈUnited States simplyshipley

The "drupal/recommended-project" for version 10.1.5 requires "composer/installers" version ^2.0, but "drupal/fontawesome" requires "composer/installers" version ^1.2.0.

This is fixed in the dev version of the fontawesome module, but here's a patch to allow using "composer/installers": "^1.2.0 || ^2.0".

I'm not sure if this fixes the issue downloading the library using drush, but I use the "wikimedia/composer-merge-plugin" and it downloads the fontawesome library after this patch is applied. The README.md in the fontawesome module explains how to config the "wikimedia/composer-merge-plugin".

Production build 0.71.5 2024