Account created on 18 March 2008, about 17 years ago
#

Merge Requests

Recent comments

πŸ‡ΊπŸ‡ΈUnited States koppie

I've opened an MR with a fix! Patch is here: https://git.drupalcode.org/project/openai_client/-/merge_requests/7.patch

Now waiting for testing/approval. In the meantime you can load the patch into your composer.json.

πŸ‡ΊπŸ‡ΈUnited States koppie

koppie β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States koppie

Bad news: I can load the patch from the merge request, but composer doesn't work that way; it needs to see compatibility in the module's composer.json before it will download the file. Even with the drupal-lenient composer add-on, it doesn't work, because there's a requirement for the openai-php client library.

Good news: The solution is easy: merge the MR into the dev version of the module. This is RISKY because we are releasing a new version of the module before testing. However, it is the dev version of the module, so anyone using it should be aware that it is not meant for production sites.

Pardon our dust. Merge incoming!

πŸ‡ΊπŸ‡ΈUnited States koppie

koppie β†’ changed the visibility of the branch d11-follow-up to hidden.

πŸ‡ΊπŸ‡ΈUnited States koppie

I'm picking this up.

I tried installing openai_client on a D11 site, and got a composer error. I'm guessing we need to add something to composer.json, for compatibility - so I'm opening a new MR for that. Stay tuned...

πŸ‡ΊπŸ‡ΈUnited States koppie

koppie β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States koppie

Comment #66 is three years old, and yet we have no stable fix for this issue.

How about a module?

I've taken @junaidpv's excellent work and packaged it as a contrib module, ready to download with composer: https://www.drupal.org/project/update_config_entity β†’

The only change I made was to add support for Drupal 11. Patches are welcome!

Roadmap:

  • In 10 days I can apply for Drupal security coverage for this new project. I will definitely opt in.
πŸ‡ΊπŸ‡ΈUnited States koppie

I had the same problem with uninstalling this module. It's because you add a reaction field, and then add permissions, and then you can't remove the field because of the permissions. For anyone else who wandered here because of Google, here's the fix:

  1. Get your environment back to a "sane" state:drush cim
  2. Remove reaction permissions using the Drupal GUI
  3. Remove the field using the Drupal GUI
  4. Uninstall the module: drush pm:uninstall votingapi_reaction
πŸ‡ΊπŸ‡ΈUnited States koppie

koppie β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States koppie

Thanks @kristen-pol, I've gone through one more time to find any remaining references to README.txt in the code base, and I think I've got them all. Please test.

πŸ‡ΊπŸ‡ΈUnited States koppie

Whoops, @skessler's latest version still deletes modules/README.txt. Here's a new version that renames instead of deletes. @kristen-pol I'll let you create the MR since I've never done that in the context of d.org. :-)

πŸ‡ΊπŸ‡ΈUnited States koppie

I'm uploading my own version of the patch with only one change: rename modules/README.txt to modules/README.md, instead of deleting it. Please test.

πŸ‡ΊπŸ‡ΈUnited States koppie

The patch applies cleanly! However, I noticed one remaining issue: modules/README.txt gets deleted. Was that intentional?

I'm keeping this marked as "needs work" until this last issue gets resolved.

πŸ‡ΊπŸ‡ΈUnited States koppie

I'm jumping on this issue as part of the mentored contribution at Drupalcon 24!

πŸ‡ΊπŸ‡ΈUnited States koppie

Rather than apply this patch, I made the same updates manually, and rolled a new stable version to encourage people to use this module in newer versions of Drupal.

πŸ‡ΊπŸ‡ΈUnited States koppie

Thanks for the patch, and thanks for testing!

Development version: 8.x-1.x-dev updated 14 Feb 2024 at 02:45 UTC

Production build 0.71.5 2024