Glad to read that and I will follow the progression there.
In the meantime, I post this patch for anyone wanting to fix the bug while we wait for the replacement, as it can impact a lot of websites like ours.
Glad to read that and I will follow the progression there.
In the meantime, I post this patch for anyone wanting to fix the bug while we wait for the replacement, as it can impact a lot of websites like ours.
We have the same problem on our website. I tested the one line strictly related to the issue in #18 and it fixes the problem.
Steps to reproduce :
- Create a new thread at /private-message/create
- Add an user by searching its username and clicking it
- Add multiples users
- Send the message
- The behavior is erratic and you end up with one user (the last one searched), sometimes two, but never the full list of users you choose.
Proposed resolution :
It's easier to see what's happening when you remove the "display: none" on the #edit-members-wrapper element.
With the current code, when you add a new user, at one point the list of members in this hidden input is reset, with only the last member added in it. It should not be.
$('#private-message-add-form .form-submit').mousedown();
This selector in the current code seems too broad. It selects all the .form-submit elements in the form instead of selecting only the input used to add an empty form element to the hidden member list, as this comment explain :
// The username cannot be inserted, so the 'add element' link is clicked
// and the username is set to be entered upon ajax complete.The update proposed by @sebastix in #18 (thanks Sebastian !) fixes it by targeting the right button instead of triggering mousedown on all these inputs. After apply this change, the behavior is always right. Adding and removing users works well.
Hope I'm helping. Do you need other info @eelkeblok ? The MR no longer apply to the current 3.0 but maybe you can update it or I can do a new one.
MR13 works for me with a subtheme of claro. Merci DuaelFr !