Reviewed and merged :)
Thanks for reviewing, MR has been merged.
mamoschli → made their first commit to this issue’s fork.
Released in 1.1.0
Released in 1.1.0
mamoschli → changed the visibility of the branch 1.0.x to hidden.
Thanks, looks good to me, MR is merged.
mamoschli → made their first commit to this issue’s fork.
mamoschli → made their first commit to this issue’s fork.
I've added the alter hook so other modules can alter the version string.
mamoschli → made their first commit to this issue’s fork.
Published in version 1.0.2
I've created a MR that uses the untranslated string instead of the translation.
mamoschli → created an issue.
@marcoliver Looks great, I have one suggestion though: I think it might be good to have the logic of actually getting the current version in some kind of manager class instead of it being directly inside the hook_toolbar hook. I would imagine this would be preferable if someone wants to for example display the version somewhere else. While at it we could also add an "alter" hook so the version string can be altered. This is optional but might be a lifesaver for situations where you don't have complete control over the version set in the environment.
That said it would be a perfect next release with the current implementation!