🇩🇪Germany @frega

+1 this has just bitten me, too. Please consider merging this.

frega → created an issue.

Fixed in https://git.drupalcode.org/issue/search_api_decoupled-3427443

frega → made their first commit to this issue’s fork.

@wimleers - a quick pointer to #52 so it doesn't lost. I am not sure the UX is quite optimal yet (body field label and text input selector pushed outside the viewport, see video in #52)

Reacquainting myself with core contrib and its linting processes, sorry🤦.

Sorry for the noise, coding standard fixes and cspell-related issue resolved. only-test.patch should fail the other one should pass.

Here a (functional js) test-only patch (failing) and a passing test with CSS attached.

As stated in #52 I see some UX issues, but this can easily be adjusted accordingly.

I am not a UX expert, so I am not sure if this is really problematic :). I'd like to point out though that the suggested max-height only considers the "ckeditor-editor part". The label, help text and text format selector will not be (fully) visible in the viewport when the CKEditor has reached it's maximum height.

I attached a video to demonstrate this. Demo styling has been applied: ckeditor (light yellow background) grows to fill the full viewport (minus drupal-specific "safe displace areas") but parts of the complete drupal field (light blue background) are pushed out of the full viewport.

Also not a CSS person, but 100vh used (?) to be problematic when used on mobile (_native_ not desktop-responsive) where relying on 100vh for "full viewport" can be tricky (e.g. https://chanind.github.io/javascript/2019/09/28/avoid-100vh-on-mobile-we...).

PS. I'd be happy to give a shot at amending the existing nightwatch test (adding "maximum height") in drupal/core/modules/ckeditor5/tests/src/Nightwatch/Tests/ckEditor5EditorHeightTest.js ...

Wim Leers → credited frega → .

Sorry I didn't see / know of #3273755 when doing a little stuff on contrib weekend; feel free to mark as duplicate. Will follow @wimleers suggestion and review / RTBC the other one ...

Setting back to needs review, as the last patch should _fail_ (rerolled test-only patch).

Rerolled as MR.

Adjusted `3336446-4-test-only-FAIL.patch` to reflect removal of `loading="lazy"` attributes in this filter (@see https://git.drupalcode.org/project/drupal/-/commit/a266ba6e).

Assigning this to me, to reroll patch.

Working on this to fix order of css-statements.