🇬🇧United Kingdom @stewsnooze

Account created on 17 February 2008, over 17 years ago
#

Recent comments

🇬🇧United Kingdom stewsnooze

merged, thanks for your contribution.

🇬🇧United Kingdom stewsnooze

We've put this patch into production and it works.

🇬🇧United Kingdom stewsnooze

I'm not sure I agree with that. Even the function name is called getNewResults() but will actually always provide all future results. Thus meaning that this module will not alert you once to a new result which it claims to do.

Later on in the module on line 294 there is code to force a return of the result set which I think may be the reason we always get the returned set rather than only new results that haven't been saved into saveKnownResults()

    // Same when we used a date field, but in this case with results.
    if ($date_field) {
      return $results;
    }

If you are not against it I still think there is a completely valid case where some work could be done here to ensure the result set should not constantly have future dates items. We are happy to do the work but I do think this is a valid use case to strengthen the module.

🇬🇧United Kingdom stewsnooze

also fixed Demi-sexual as it is Demisexual

🇬🇧United Kingdom stewsnooze

There is no such word as Bi-sexual. The word is Bisexual so I have fixed the typo here

Production build 0.71.5 2024