🇫🇮Finland @gaards

It would be good to do the same changes to 4.x branch as well.

I added a MR targeting the 4.x version, fixing these issues reported by the Upgrade Status module:

FILE: modules/contrib/graphql_twig/src/Controller/ArgumentResolver.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 16   Class Drupal\graphql_twig\Controller\ArgumentResolver       
                    implements deprecated interface                             
                    Symfony\Component\HttpKernel\Controller\ArgumentValueResolve
                    rInterface: since Symfony 6.2, implement                    
                    ValueResolverInterface instead                              
--------------------------------------------------------------------------------

FILE: modules/contrib/graphql_twig/src/GraphQLNodeVisitor.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 16   Class Drupal\graphql_twig\GraphQLNodeVisitor extends        
                    deprecated class Twig\NodeVisitor\AbstractNodeVisitor: since
                    3.9 (to be removed in 4.0)                                  
--------------------------------------------------------------------------------

FILE: modules/contrib/graphql_twig/tests/src/Kernel/BlockTest.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 21   Property                                                    
                    Drupal\Tests\graphql_twig\Kernel\BlockTest::$modules        
                    property must be protected.                                 
--------------------------------------------------------------------------------

FILE: modules/contrib/graphql_twig/tests/src/Kernel/EntityRenderTest.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 25   Property                                                    
                    Drupal\Tests\graphql_twig\Kernel\EntityRenderTest::$modules 
                    property must be protected.                                 
--------------------------------------------------------------------------------

FILE: modules/contrib/graphql_twig/tests/src/Kernel/RouteTest.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 18   Property                                                    
                    Drupal\Tests\graphql_twig\Kernel\RouteTest::$modules        
                    property must be protected.                                 
--------------------------------------------------------------------------------

FILE: modules/contrib/graphql_twig/tests/src/Kernel/ThemeTest.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 32   Property                                                    
                    Drupal\Tests\graphql_twig\Kernel\ThemeTest::$modules        
                    property must be protected.                                 
--------------------------------------------------------------------------------

FILE: modules/contrib/graphql_twig/tests/src/Unit/GraphQLTwigExtensionTest.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 30   Missing call to parent::setUp() method.                     
--------------------------------------------------------------------------------

FILE: /var/www/html/vendor/symfony/deprecation-contracts/function.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 25   Since twig/twig 3.9: Twig node                              
                    "Drupal\graphql_twig\GraphQLNode" is not marked as ready for
                    using "yield" instead of "echo"; please make it ready and   
                    then flag it with the #[YieldReady] attribute.              
--------------------------------------------------------------------------------

FILE: modules/contrib/graphql_twig/graphql_twig.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 5    Value of core_version_requirement: ^9 || ^10 is not         
                    compatible with the next major version of Drupal core. See  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

FILE:
modules/contrib/graphql_twig/tests/themes/graphql_twig_test_theme/graphql_twig_t
est_theme.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 7    Value of core_version_requirement: ^9 || ^10 is not         
                    compatible with the next major version of Drupal core. See  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

gaards → created an issue.

I added a MR for version 4 of the GraphQL Twig module, including 3lis patch → above, and the yield patch → I added above.

As a note our organization has used the patch by 3li on our sites for some time already without issues.

The Upgrade status module also reports this warning:

Since twig/twig 3.9: Twig node "Drupal\graphql_twig\GraphQLNode" is not marked as ready for using "yield" instead of "echo"; please make it ready and then flag it with the #[YieldReady] attribute.

I added a patch for v4 of GraphQL Twig that should solve this, following the logic that was done for Drupal core:

https://git.drupalcode.org/project/drupal/-/commit/5a43c22fa3d7665a0e05a...

There is already a Drupal 10 compatible release including these changes, closing this as outdated.

There is already a Drupal 10 compatible release including these changes, closing this as outdated.

Drupal 9 is EOL since November 1st, 2023: https://www.drupal.org/about/announcements/blog/drupal-9-is-end-of-life →

Closing this issue as outdated.

Updated the patch with a small fix to the option name which was incorrect, causing the batch size to not work (thanks to olli → for spotting it).

The latest patch provided here didn't apply, so I created a new one from the latest diff of merge request 19.