🇳🇱Netherlands @theemstra

Hi @mably,

Thanks for your offer. I'd welcome a maintainer and you seem to have more than enough experience. Eventually it's up to @jhedstrom to give the go-ahead.

Hi, I've asked the main maintainer to take a look at this and release it. He'll be working towards the next release.

@jhedstrom Can you create a release for the patch? I've already tagged it.

It was incorrect, it shouldn't go to ^2.0, but to ^2.2.1 which was done in 3cff0c74b5f81339b16814f81a4b4d1544ff9002

jhedstrom → credited theemstra → .

Can confirm, works for me too.

The issues mentioned in #13 should already have been resolved in the latest commits done after previous posts.

theemstra → made their first commit to this issue’s fork.

theemstra → made their first commit to this issue’s fork.

theemstra → made their first commit to this issue’s fork.

Hi,

The LICENSE file has been replaced, the second encoder declaration was added in a previous commit earlier last week.

Thanks for the extensive feedback so far.

Fixed #7 -> The watchdog_exception deprecated in D10 and will be removed in D11, so implemented the recommended exception logger
Fixed #8

Thanks, I was able to resolve all the warnings and errors as provided by PHPCS.

theemstra → created an issue.

theemstra → created an issue.

Duplicate of #3221114

Implemented in dev

Thanks for your contribution, will be merged soon.

Now available in the git version, needs a bit more testing in edge cases.

Beautiful! Thanks!

theemstra → made their first commit to this issue’s fork.

theemstra → made their first commit to this issue’s fork.

theemstra → made their first commit to this issue’s fork.

theemstra → made their first commit to this issue’s fork.

Thanks! Merged and will be published in next release.

Thanks for the report. Updated the readme.

There are some limitations to box/sprout that would remove some functionality from the module that some people might be using, including "no automatic column widths, no column number/string formatting)" as per the first link you provided.
We could provide the option to choose one of the engines, with the tradeoffs of each library.

https://git.drupalcode.org/project/xls_serialization/-/merge_requests/10

Simple testing gave me no errors and normal result. Made a seperate branch on the repo if anyone else wants to test this.
When confirmed, will merge.

Thanks, merged into dev! Credits to DUdave!

Tested and reviewed. Thanks for the MR