richo_au → credited loziju → .
richo_au → credited loziju → .
richo_au → credited loziju → .
richo_au → credited loziju → .
richo_au → credited loziju → .
richo_au → credited loziju → .
richo_au → credited loziju → .
surabhi-gokte → credited loziju → .
surabhi-gokte → credited loziju → .
surabhi-gokte → credited loziju → .
surabhi-gokte → credited loziju → .
surabhi-gokte → credited loziju → .
surabhi-gokte → credited loziju → .
surabhi-gokte → credited loziju → .
surabhi-gokte → credited loziju → .
MR past the tests, but it's because there's no test on ldap_last_authserv yet. The feature not working yet for creating new user.
Remaining things to do:
- Fix the logic for both provisioning new user and authenticating existing user
- Write test for ldap_last_authserv
@bluegeek9
> This file should be removed: DrupalUserProcessor.php.orig
My bad, the file was added inadvertently.
The tests should pass now.
Besides the failing test, I also identified another error (not caught by any test!) when creating a new user. Apparently my previous fix only solved the authentication of user, but not provisioning of user.
Let's see if the latest few commits should do it.
Changing status to needs review.
loziju → created an issue.
@bluegeek9 appreciate your guidance for my first attempt to add this feature in MR62. Please let me know what needs to be improved.
@basvredeling thanks for looking into this!
It's not really about admin title (paragraph), but about paragraph_field block label (LB block field, see the screenshot → ). Admin title can be blank, as you correctly identified (thus your code tries to get the summary when it's blank). But block label must be populated, even when it's suppressed.
Since that part of the code is trying to obtain the admin title, and then assign it to the label field, I chose to update the code at that portion. After all, layout_builder_paragraphs will need to create the paragraph_field block first before creating the paragraph and therefore there is nothing to be used as label. So might as well using uuid as it's guaranteed to be unique. To be precise, the actual admin title for the paragraph can be blank or non-blank, just that the paragraph is not created yet at the point of creation of paragraph_field block form, thus we need to use some other value for the block label. And more importantly, beyond layout_builder_paragraphs, other new contrib / custom modules can always utilise paragraph_field block form without existing paragraph, so it's important to have proper error handling here.
Furthermore, the purpose of block label is to show the text when "Show content preview" checkbox is unchecked in LB. The admin user of layout_builder_paragraphs can always update the label after the paragraph is inserted into LB. But upon creating the paragraph / paragraph_field block itself, the label is not important.
And finally, for typical use case of paragraph_blocks module, assigning uuid to block label will never happen. This only happens when paragraph is not created while paragraph_field block form is already built.
As for 3.1.5, it gave error with layout_builder_paragraphs, but I didn't have time to look into it yet. I reckon it's due to the new arguments added for the services, which is introduced in 3.1.4. What is inside 3.1.5 that you'd like me to test?
forgot to change the status!
There, you'll find an option that allows you to "Copy README.md or README.txt file to the description."
I did, but this led to the link copied without the href. Is this a known issue?
Thanks for checking!
First time I publish module in d.o and I realise that there is no easy way to keep the documentation updated between README.md and the project page. I experimented with converting the README.md file using markdown preview and that resulted in some of the nofollow links. Then I tried to copy the README.md from the field UI, but it stripped the links.
I hope the new revision is good now.
Question: How to easily keep the README.md and project page description in sync?
Thanks apaderno!
Oh, and I'm also not sure if I should have created the issue under Content! Do let me know if I should log this elsewhere, like infrastructure?