Vienna
Account created on 26 January 2012, about 13 years ago
#

Recent comments

πŸ‡¦πŸ‡ΉAustria nebel54 Vienna

Fixed the errors, uit left the tasks from the "Ignore" section untouchted, as fixing them would break Drupal 9 compability. Will create a separate update for those issues.

πŸ‡¦πŸ‡ΉAustria nebel54 Vienna

nebel54 β†’ created an issue.

πŸ‡¦πŸ‡ΉAustria nebel54 Vienna

The default branch is set to 2.x now. Thanks for reporting!

πŸ‡¦πŸ‡ΉAustria nebel54 Vienna

Ah, damn it - I am not able to do that. I will try to get in touch with @michaelmol to elevate my permissions to maintainer level.

πŸ‡¦πŸ‡ΉAustria nebel54 Vienna

As a quick update from the coffee side: I just released a new version 2.0.1 that includes https://www.drupal.org/project/coffee/issues/3494208 πŸ“Œ Get coffee data only when the search box is opened Active which should solve the issue for now, as the AJAX request is only fired when needed.

πŸ‡¦πŸ‡ΉAustria nebel54 Vienna

@pameeela - sure, I have created the release 2.0.1 now. Good luck with the Drupal CMS launch!

πŸ‡¦πŸ‡ΉAustria nebel54 Vienna

Thanks for reporting, I went with the MR from https://www.drupal.org/project/coffee/issues/3320438 πŸ“Œ Replace README.txt with README.md RTBC

πŸ‡¦πŸ‡ΉAustria nebel54 Vienna

nebel54 β†’ made their first commit to this issue’s fork.

πŸ‡¦πŸ‡ΉAustria nebel54 Vienna

Thanks for reporting - this was fixed in #3428399

πŸ‡¦πŸ‡ΉAustria nebel54 Vienna

Thanks catch and kumareshbaksi! I checked the MR and did a local test, everything is looking good to me. Will merge it now to 2.x.

πŸ‡¦πŸ‡ΉAustria nebel54 Vienna

Sorry @vladimiraus - for some reason I thought the credit in the commit message triggers the credit system. Thanks for reporting it!

πŸ‡¦πŸ‡ΉAustria nebel54 Vienna

Thanks everyone! I have just created a new 2.x branch for future development and released the D11 compatible version 2.0.0.

πŸ‡¦πŸ‡ΉAustria nebel54 Vienna

Patch #5 works like a charm. Thanks for that!

Personally I would have stored the reference to the chosen drop element in a variable instead of using jQuery a second time to find it, but I assume it does not really make a difference. Eg.

var $drop = $element.next().find('.chosen-drop');
$drop.css('position', 'static');
$element.trigger('dialogContentResize');
// Back to absolute.
$drop.css('position', '');
πŸ‡¦πŸ‡ΉAustria nebel54 Vienna

Nebel54 β†’ made their first commit to this issue’s fork.

πŸ‡¦πŸ‡ΉAustria nebel54 Vienna

Thanks for the hospitality :)

πŸ‡¦πŸ‡ΉAustria nebel54 Vienna

Thanks for your patches! I have commited them now to 8.x-1.x.

πŸ‡¦πŸ‡ΉAustria nebel54 Vienna

I second Klausi's proposal! It would be great if the 7.x branch could be still maintained, as Drupal 7 still has quite some time until EOL.

πŸ‡¦πŸ‡ΉAustria nebel54 Vienna

I do like Coops solution as it is very modular and flexible!

But based on Berdir's request to keep it lightweight I have created an alternative implementation with a simple hook in issue #3351543 ✨ Introduce hook to alter the download response Active .

Production build 0.71.5 2024