sean_fremouw → created an issue. See original summary → .
sean_fremouw → created an issue.
sean_fremouw → created an issue.
Probably too simple patch.
sean_fremouw → created an issue.
After further exploration, for me at least, this occurs when I leave my cursor in the caption text box. If I leave the caption on but reselect the media item (so the border around the image and caption changes from yellow to blue) the alt text button works. It makes sense from a programmatic view point that this would happen since the alt text is a property of media item and not the caption. However, from a user perspective it just seems like the button isn't working. If there could be a message to the user that the media item needs to be in focus or, better yet, the functionality could determine the media object to which the caption belongs and act on it, that would be great.
I got very similar stack trace:
Uncaught CKEditorError: Cannot read properties of null (reading 'is')
at at.viewToDom (ckeditor5-dll.js?v=44.0.0:5:254805)
at v (drupalMedia.js?ssmmkd:1:12453)
at k._showForm (drupalMedia.js?ssmmkd:1:16293)
at Q.<anonymous> (drupalMedia.js?ssmmkd:1:15098)
at Q.fire (ckeditor5-dll.js?v=44.0.0:5:725118)
at l.<anonymous> (ckeditor5-dll.js?v=44.0.0:5:541422)
at Te.s (ckeditor5-dll.js?v=44.0.0:5:530769)
at Te.fire (ckeditor5-dll.js?v=44.0.0:5:725118)
at HTMLButtonElement.t (ckeditor5-dll.js?v=44.0.0:5:735357)
Merge request for 2.1.x created: https://git.drupalcode.org/project/metatag/-/merge_requests/180
As for how to reproduce, I'm not really sure. I do have drupal/computed_field 3.0.0 installed and the bug did seem to be on nodes that have a computed field, but tracing through the call stack I couldn't see why that would matter. It could totally be a red herring that just jumped out at me because both modules are "computing" a value.
In my case, ensureComputedValue() was being called while computeValue() was still computing the value via a call to $renderer->executeInRenderContext. The attached patch adds a flag to prevent computing if already in the process of computing.
Stuck overlay issue has core patch here: https://www.drupal.org/project/drupal/issues/3399951 🐛 ajax_page_state leaks through request in Views Ajax Needs work And it appears to also fix JS errors.
Patch mentioned by GPZ in comment #5 fixed issue for me as well.
Agree that stuck overlay is not exclusive Field Group problem. Thrown errors, however, do not appear to be related to stuck overlay -- I get errors whether I get stuck overlay or not.
Noting stuck overlay problem has Drupal core issue opened here: https://www.drupal.org/project/drupal/issues/3415636 🐛 Media Library modale window covered by black overlay after using pager or search Active
I have almost identical experience. However, I only experience in reference fields. Media Library via CKEditor (v4) works fine. In fact, if I first use Media Library within CKEditor and then use Medial Library for a reference field it now works fine. I do not have to actually select the media item -- just use the pager or search.
Noting this related issue in Field Group ( https://www.drupal.org/project/field_group/issues/3415633 🐛 Drupal.FieldGroup is undefined when using Media Library modal Active ) but agree with lindsay.wils that the error thrown is a red herring. The error discussed in that item is thrown for me in all use cases -- CKEditor or reference field as well as black overlay getting stuck or not.
Added checks on queries in install file to patch in #3.
Initial attempt at patch. Works for me.
sean_fremouw → created an issue.
sean_fremouw → created an issue.
I assume there must have been some rationale for unsetting GA page attachments originally, so I don't know if removing that code is the best option, but here's a patch for 2.x branch that does that for anyone who needs it.
Re-roll patch of #16 without what appears to be email header and footer lines?
I've had this module on two sites I maintain for quite some time and have not run into any issues when upgrading to various flavors of core 9.5.x. Currently one on 9.5.8 and one on 9.5.9
Initial proposed patch
sean_fremouw → created an issue.
sean_fremouw → created an issue.