🇺🇸United States @dLux

added || ^11

gonna consider this resolved; it is in alignment with 📌 module category both in the extend page and project homepage Fixed

was hoping for a discussion but seeing it implemented kinda settles it for me; it now behaves like the admin toolbar module, and while this module isn't strictly for 'administration', it does seem to have better siblings there than than under 'navigation'..

thanks!

added getCacheTags() to src/Form/ModuleConfigurationForm.php, and $variables['#cache']['tags'] = $config->getCacheTags(); to login_dialog_hotkey.module/login_dialog_hotkey_page_attachments, and now the caches no longer need to be cleared after saving module settings

it now has its own permission

this should remain on the version it was reported against, 0.0.1; it was fixed in the 1.0.0-beta1 release.

as i'm understanding the issue queue, this should remain on the version it was reported against, 0.0.1; it was fixed in the 1.0.0-beta1 release.

ah ic, and it seems the .js-form-item-keydisplay is consistent throughout? that's awesome, thanks!

i think i should leave the issue on 1.0.0-beta1 and mention that it is fixed in 1.0.0-beta2

this looks good, i'm looking into merging this..

why is this js class better? i have a d9.5.10 and it's ok there, your change works all around so i'm wondering some background on why it's better for d9 compability..?

it could have its own permission; i'll do that..

it doesn't need to happen, nor be messaged. there are many modules that do neither.

dLux → created an issue.

dLux → created an issue.

dLux → created an issue.

dLux → created an issue.

version bump

version bump

should be fixed in 1.x-dev

created a 1.x branch, these fixes are now in the current 1.x-dev, almost ready for a 1.0.0-rc1 but i'd like to look at a few more issues

the fix is in login_dialog_hotkey-3411869/3411869-phpcs_fixes

this fix is in 3411869 along with the phpcs fixes

ok these should be good, i also added/fixed 3411865 hook_help function

excellent; will do..

i'd wondered if this module should have a help function, and it seems it should..

thx for reporting this!

wow u were fast to notice that it wasn't uploaded yet; it's now got it's code in there..

many of the errors reported here were the types of things i wondered about and wanted feedback on; i very much appreciate the input!

i'll do a pass of these errors and see how far i can get..

thanks again for the feedback!

is it wrong for me to assign this to myself? this is my first published module, so i'm still learning the processes..