As an update - if you delete (or comment) the code in web/modules/contrib/date_recur/src/DateRecurOccurrences.php for the "onEntityDelete" function, you can remove the field, and uninstall the module cleanly. I'm not clear on why this code exists considering core will handle deleting the field, and the function itself is not commented clearly.
I have several sites running date_recur, and cannot remove the field on any of them without an error. Other fields are ok to remove, unless you have tried to remove the date_recur field first, and then removing any other field gives the same error. The error I'm seeing is:
Drupal\Core\Database\DatabaseExceptionWrapper: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'db.date_recur__node__field_test' doesn't exist: DELETE FROM "date_recur__node__field_test" WHERE "entity_id" = :db_condition_placeholder_0; Array ( [:db_condition_placeholder_0] => 1 ) in Drupal\date_recur\DateRecurOccurrences->onEntityDelete() (line 158 of modules/contrib/date_recur/src/DateRecurOccurrences.php).
I created a clean Drupal 10.4.1 install locally, and installed 3.8.1 and am getting the error. The error makes uninstalling this module impossible.
Steps to reproduce:
- Install a clean Drupal 10.4.1
- Install date_recur version 3.8.1
- Add a date recur field to the "Basic Page" content type
- Add a test basic page and make sure the date field is set and has a start and end date for occurrences, as well as a time zone
- Save the page
- Try to remove the recurring date field from the content type
I apologize, my previous comment should have been added to https://www.drupal.org/project/date_recur/issues/3328422 🐛 DateRecurOccurrences::onEntityTypeDelete makes it impossible to delete an entity type and its code at the same time Needs work instead of this issue. Closing.
I don't think this is a Drupal core issue, as I have several sites running date_recur, and cannot remove the field on any of them without an error. Other fields are ok to remove, unless you have tried to remove the date_recur field first, and then removing any other field gives the same error. The error I'm seeing is:
Drupal\Core\Database\DatabaseExceptionWrapper: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'db.date_recur__node__field_test' doesn't exist: DELETE FROM "date_recur__node__field_test" WHERE "entity_id" = :db_condition_placeholder_0; Array ( [:db_condition_placeholder_0] => 1 ) in Drupal\date_recur\DateRecurOccurrences->onEntityDelete() (line 158 of modules/contrib/date_recur/src/DateRecurOccurrences.php).
I created a clean Drupal 10.4.1 install locally, and installed 3.8.1 and am getting the error.
Steps to reproduce:
- Install a clean Drupal 10.4.1
- Install date_recur version 3.8.1
- Add a date recur field to the "Basic Page" content type
- Add a test basic page and make sure the date field is set and has a start and end date for occurrences, as well as a time zone
- Save the page
- Try to remove the recurring date field from the content type
This error occurs on several of our sites when we try to remove the date_recur field. I have tried it on simplytest.me with version 3.3.0 on
a clean Drupal 10.4.1 and the same error occurs. I updated my local site to use version 3.8.1 and have the same error. I cannot test version 3.8.1 on Drupal 10 on simplytest.me so I have not tried that, but I'm guessing the same error will occur, since it happens on our site. Dropping the database and importing a snapshot as mentioned in #29 does not resolve the issue for us.
I updated the code to work with the latest version. Mostly because we still have a site using it.
@itamair Maybe I'm confused, but the commit you linked adds the (most likely) malicious library back into the module (https://github.com/polyfillpolyfill/polyfill-service/). Why did you decide to not use Fastly in this case? We are attempting to get rid of all the references to polyfill.io out of our sites' codebases.