_kash_ β made their first commit to this issueβs fork.
JS files included in the head tag:
When Aggregation is on and it breaks:
<script src="/sites/default/files/js/js_K8Mo2AaDmJRTx-xL2V8u4FwqcVJzlADxVY5f7DaH2Lw.js?scope=header&delta=0&language=en&theme=CUSTOM_olivero&include=eJx9UEFywyAM_BCBN_QljAwqUawgRsiJn1-c2p1J2uaEVrtarUhSDVdbgEPWpQH79NM5MdW5uySKBwnJ6IYPwhWRwhgNSih2fYZQXrGHC6zDixlap4klzWFzdjfCe48ZDCKuTdTCr46b0Az1gTrm-Ek8YA8FKyrwf_RwwEZpHvXTEXsIdMLjGJXQETSdT3fK6EyEJ9Cwvw7ylWrcUfxW7gNDu2zCRV16941_Wh0LvCniG8qfZWSkYVbtNZzHnqDhxzbsJiqxUcNwFF9ekrpi"></script>
<script src="/modules/contrib/google_tag/js/gtm.js?sksl22"></script>
<script src="/modules/contrib/google_tag/js/gtag.js?sksl22"></script>
<script src="/sites/default/files/js/js_RzaCuAcclrup1zj-6jwLbIM8SzabRtiGnvg1ZzSx2mc.js?scope=header&delta=3&language=en&theme=CUSTOM_olivero&include=eJx9UEFywyAM_BCBN_QljAwqUawgRsiJn1-c2p1J2uaEVrtarUhSDVdbgEPWpQH79NM5MdW5uySKBwnJ6IYPwhWRwhgNSih2fYZQXrGHC6zDixlap4klzWFzdjfCe48ZDCKuTdTCr46b0Az1gTrm-Ek8YA8FKyrwf_RwwEZpHvXTEXsIdMLjGJXQETSdT3fK6EyEJ9Cwvw7ylWrcUfxW7gNDu2zCRV16941_Wh0LvCniG8qfZWSkYVbtNZzHnqDhxzbsJiqxUcNwFF9ekrpi"></script>
When aggregation is off and it is fine:
<script src="/core/misc/touchevents-test.js?v=10.3.6"></script>
<script src="/core/assets/vendor/jquery/jquery.min.js?v=3.7.1"></script>
<script src="/core/assets/vendor/once/once.min.js?v=1.0.1"></script>
<script src="/core/misc/drupalSettingsLoader.js?v=10.3.6"></script>
<script src="/core/misc/drupal.js?v=10.3.6"></script>
<script src="/core/misc/drupal.init.js?v=10.3.6"></script>
<script src="/core/assets/vendor/tabbable/index.umd.min.js?v=6.2.0"></script>
<script src="/core/misc/progress.js?v=10.3.6"></script>
<script src="/core/assets/vendor/loadjs/loadjs.min.js?v=4.3.0"></script>
<script src="/core/misc/debounce.js?v=10.3.6"></script>
<script src="/core/misc/announce.js?v=10.3.6"></script>
<script src="/core/themes/olivero/js/navigation-utils.js?v=10.3.6"></script>
<script src="/core/themes/olivero/js/checkbox.js?v=10.3.6"></script>
<script src="/core/themes/olivero/js/messages.js?v=10.3.6"></script>
<script src="/core/misc/message.js?v=10.3.6"></script>
<script src="/core/themes/olivero/js/message.theme.js?v=10.3.6"></script>
<script src="/core/misc/ajax.js?v=10.3.6"></script>
<script src="/modules/contrib/google_tag/js/gtm.js?sksnk5"></script>
<script src="/modules/contrib/google_tag/js/gtag.js?sksnk5"></script>
<script src="/modules/contrib/google_tag/js/gtag.ajax.js?sksnk5"></script>
<script src="/core/modules/toolbar/js/toolbar.anti-flicker.js?v=10.3.6"></script>
:/opt/drupal# drush pm:list --status=enabled
--------------------- --------------------------------------------------------- --------- --------------
Package Name Status Version
--------------------- --------------------------------------------------------- --------- --------------
Core Automated Cron (automated_cron) Enabled 10.3.6
Core BigPipe (big_pipe) Enabled 10.3.6
Core Block (block) Enabled 10.3.6
Core Block Content (block_content) Enabled 10.3.6
Core Breakpoint (breakpoint) Enabled 10.3.6
Core CKEditor 5 (ckeditor5) Enabled 10.3.6
Core Comment (comment) Enabled 10.3.6
Core Configuration Manager (config) Enabled 10.3.6
Core Contact (contact) Enabled 10.3.6
Core Content Moderation (content_moderation) Enabled 10.3.6
Core Contextual Links (contextual) Enabled 10.3.6
Field types Datetime (datetime) Enabled 10.3.6
Field types Datetime Range (datetime_range) Enabled 10.3.6
Core Database Logging (dblog) Enabled 10.3.6
Core Internal Dynamic Page Cache (dynamic_page_cache) Enabled 10.3.6
Core Text Editor (editor) Enabled 10.3.6
Core Field (field) Enabled 10.3.6
Core (Experimental) Field Layout (field_layout) Enabled 10.3.6
Core Field UI (field_ui) Enabled 10.3.6
Field types File (file) Enabled 10.3.6
Core Filter (filter) Enabled 10.3.6
Core Help (help) Enabled 10.3.6
Core History (history) Enabled 10.3.6
Field types Image (image) Enabled 10.3.6
Core Layout Builder (layout_builder) Enabled 10.3.6
Core Layout Builder Expose All Field Blocks Enabled 10.3.6
(layout_builder_expose_all_field_blocks)
Core Layout Discovery (layout_discovery) Enabled 10.3.6
Field types Link (link) Enabled 10.3.6
Core Media (media) Enabled 10.3.6
Core Media Library (media_library) Enabled 10.3.6
Core Custom Menu Links (menu_link_content) Enabled 10.3.6
Core Menu UI (menu_ui) Enabled 10.3.6
Migration Migrate (migrate) Enabled 10.3.6
Migration Migrate Drupal (migrate_drupal) Enabled 10.3.6
Migration Migrate Drupal UI (migrate_drupal_ui) Enabled 10.3.6
Core MySQL (mysql) Enabled 10.3.6
Core Node (node) Enabled 10.3.6
Field types Options (options) Enabled 10.3.6
Core Internal Page Cache (page_cache) Enabled 10.3.6
Core Path (path) Enabled 10.3.6
Core Path alias (path_alias) Enabled 10.3.6
Core Password Compatibility (phpass) Enabled 10.3.6
Web services RESTful Web Services (rest) Enabled 10.3.6
Core Search (search) Enabled 10.3.6
Web services Serialization (serialization) Enabled 10.3.6
Core Shortcut (shortcut) Enabled 10.3.6
Core System (system) Enabled 10.3.6
Core Taxonomy (taxonomy) Enabled 10.3.6
Field types Text (text) Enabled 10.3.6
Core Toolbar (toolbar) Enabled 10.3.6
Core Tour (tour) Enabled 10.3.6
Core Update Manager (update) Enabled 10.3.6
Core User (user) Enabled 10.3.6
Core Views (views) Enabled 10.3.6
Core Views UI (views_ui) Enabled 10.3.6
Core Workflows (workflows) Enabled 10.3.6
Administration Admin Toolbar (admin_toolbar) Enabled 3.5.0
Administration Admin Toolbar Search (admin_toolbar_search) Enabled 3.5.0
Administration Admin Toolbar Extra Tools (admin_toolbar_tools) Enabled 3.5.0
Views Better Exposed Filters (better_exposed_filters) Enabled 6.0.6
User interface Collapsiblock (collapsiblock) Enabled 4.3.0
Other Comment Notify (comment_notify) Enabled 8.x-1.4
Other Components (components) Enabled 3.1.0
Fields Conditional Fields (conditional_fields) Enabled 4.0.0-alpha5
Config Config Split (config_split) Enabled 2.0.1
Web services Serialization (CSV) (csv_serialization) Enabled 4.0.1
Navigation Easy Breadcrumb (easy_breadcrumb) Enabled 2.0.8
Encryption Encrypt (encrypt) Enabled 8.x-3.2
Entity Print Entity Print (entity_print) Enabled 8.x-2.15
Field types Entity Reference Revisions (entity_reference_revisions) Enabled 8.x-1.12
Search Facets (facets) Enabled 2.0.8
FAQ Frequently Asked Questions (faq) Enabled 8.x-1.2
Fields Field Group (field_group) Enabled 8.x-3.6
Administration Fast Permissions Administration (fpa) Enabled 4.0.0
Other Google Tag (google_tag) Enabled 2.0.6
Spam control Honeypot (honeypot) Enabled 2.2.0
jQuery UI jQuery UI (jquery_ui) Enabled 8.x-1.7
jQuery UI jQuery UI Datepicker (jquery_ui_datepicker) Enabled 2.1.0
jQuery UI jQuery UI Slider (jquery_ui_slider) Enabled 2.1.0
jQuery UI jQuery UI Touch Punch (jquery_ui_touch_punch) Enabled 1.1.1
Other JavaScript Cookie Library (js_cookie) Enabled 1.0.1
Security Key (key) Enabled 8.x-1.19
Administration Mail Login (mail_login) Enabled 3.0.0
Mail Mail System (mailsystem) Enabled 8.x-4.5
Other Masquerade (masquerade) Enabled 8.x-2.0
Migration Migrate Files (extended) (migrate_file) Enabled 2.1.2
Migration Migrate Plus (migrate_plus) Enabled 6.0.4
Migration Migrate Tools (migrate_tools) Enabled 6.0.4
Paragraphs Paragraphs (paragraphs) Enabled 8.x-1.18
Other Pathauto (pathauto) Enabled 8.x-1.13
Permissions by Term Permissions by Term (permissions_by_term) Enabled 3.1.33
Other Redirect 403 to User Login (r4032login) Enabled 2.2.2
Fields Read-only Field Widget (readonly_field_widget) Enabled 8.x-1.6
Security Real AES (real_aes) Enabled 8.x-2.6
Other Redirect (redirect) Enabled 8.x-1.10
Content Authoring Require on Publish (require_on_publish) Enabled 8.x-1.10
Permissions Role Delegation (role_delegation) Enabled 8.x-1.3
SAML SAML Drupal Login (saml_sp_drupal_login) Enabled 4.2.3
SAML SAML Service Provider (saml_sp) Enabled 4.2.3
Search Database Search (search_api_db) Enabled 8.x-1.35
Search Search API (search_api) Enabled 8.x-1.35
Fields Smart Trim (smart_trim) Enabled 2.2.0
Mail SMTP Authentication Support (smtp) Enabled 8.x-1.4
Fields Term Reference Tree (term_reference_tree) Enabled 2.0.1
Security Two-factor Authentication (TFA) (tfa) Enabled 8.x-1.8
Other Token (token) Enabled 8.x-1.15
Administration Upgrade Status (upgrade_status) Enabled
Views Views Data Export (views_data_export) Enabled 8.x-1.4
Workbench Workbench (workbench) Enabled 8.x-1.5
Custom Launchpad And TFA (launchpad_and_tfa) Enabled
Custom Bookmark Paragraphs (bookmark_paragraphs) Enabled
Custom CUSTOM_access (CUSTOM_access) Enabled
Custom CUSTOM_analytics (CUSTOM_analytics) Enabled
Custom CUSTOM_comment_mail (CUSTOM_comment_mail) Enabled
Custom CUSTOM Email Notifications (CUSTOM_email_notifications) Enabled
Custom CUSTOM_form_update (CUSTOM_form_update) Enabled
Custom CUSTOM_menu (CUSTOM_menu) Enabled
Custom CUSTOM_migration (CUSTOM_migration) Enabled
Custom CUSTOM_result (CUSTOM_result) Enabled
Custom permissions_by_term_extra (permissions_by_term_extra) Enabled
Core Claro (claro) Enabled 10.3.6
Core Olivero (olivero) Enabled 10.3.6
Bootstrap Barrio (bootstrap_barrio) Enabled 5.5.17
CUSTOM Bootstrap (CUSTOM_bootstrap) Enabled 5.0.10
Custom CUSTOM Claro (CUSTOM_claro) Enabled
CUSTOM Olivero (CUSTOM_olivero) Enabled 10.3.6
Looked like maybe just in indenting issued. Maybe it will pass
The changes are not passing the lint test. I'll leave that for someone else... I used the Web Browser IDE and I don't know hot to use prettier there.
The code change suggested in the description worked to fix my issue.
I opened up a merge request with those changes.
Thank you lionsea
I have the same issue. I am using a sub-theme of Olivero.
Upgrading drupal/core (10.3.1 => 10.3.6)
Once JS is aggregated, it throws errors and causes javascript to stop working for other modules
The patch helped. But I still had issues with the title showing up on pages using layout builder. Unsetting the label[0] element fixed everything for me. I pushed up a change to the issue fork.
_kash_ β made their first commit to this issueβs fork.
This change adds "layout--content-medium" to the element in the Olivero pager.html.twig file.
Not sure why it was added, but it messed up the layout of my site on a views page with pagination. I had to override the template and remove the class.
https://git.drupalcode.org/project/drupal/-/commit/197d8bae7ddcab6093d30...
Leaving a comment here instead of opening a new ticket. Not sure if this is a bug, but some one else out there might be dealing with the same problem when updating to 10.3
Well, I've done some more digging and found my issue.
Upgrading dmore/chrome-mink-driver (2.9.2 => 2.9.3)
That causes my tests to fail from the JS error.
The JS error seems to exist in my current build as well... sometimes
Uncaught TypeError: this[{(intermediate value)(intermediate value)(intermediate value)}[r]] is not a function
at u.computeTids (bundle.js?v=10.2.5:8:10308)
at n (bundle.js?v=10.2.5:1:101244)
at HTMLInputElement. (bundle.js?v=10.2.5:1:101687)
at HTMLInputElement.dispatch (jquery.min.js?v=3.7.1:2:40035)
at v.handle (jquery.min.js?v=3.7.1:2:38006)
I am going to pin chrome-mink-driver to 2.9.2 and move on for now...
I've attached a screenshot along side the error.
The field actually works still. However the js error is causing my tests to fail. So I need to fix the js error.
I am narrowing down the cause.
I've successfully updated Core to 10.2.7 and PBT to 3.1.33 and the tests pass (there is no JS error)
However, when I do a composer update for the rest of the modules that need to be brought up to date, that is when I start to encounter the error.
So, it seem that the error is somehow related to one of these updates included below. So, there is a possibility this bug does not even reside with permissions by term.
I am going to try to figure out which package update introduces the error. Could take a while...
composer update --dry-run
Loading composer repositories with package information
Updating dependencies
Lock file operations: 7 installs, 45 updates, 3 removals
- Removing phenx/php-font-lib (0.5.6)
- Removing phenx/php-svg-lib (0.5.4)
- Removing textalk/websocket (1.5.8)
- Upgrading chi-teck/drupal-code-generator (3.5.0 => 3.6.0)
- Upgrading composer/class-map-generator (1.1.1 => 1.3.3)
- Upgrading composer/composer (2.7.2 => 2.7.7)
- Upgrading composer/pcre (3.1.3 => 3.1.4)
- Upgrading composer/xdebug-handler (3.0.4 => 3.0.5)
- Upgrading dmore/chrome-mink-driver (2.9.2 => 2.9.3)
- Upgrading doctrine/event-manager (2.0.0 => 2.0.1)
- Upgrading dompdf/dompdf (v2.0.7 => v3.0.0)
- Locking dompdf/php-font-lib (1.0.0)
- Locking dompdf/php-svg-lib (1.0.0)
- Upgrading drevops/behat-steps (2.2.0 => 2.3.0)
- Upgrading drupal/better_exposed_filters (6.0.3 => 6.0.6)
- Upgrading drupal/coder (8.3.23 => 8.3.24)
- Upgrading drupal/collapsiblock (4.1.0 => 4.2.0)
- Upgrading drupal/core-dev (10.2.5 => 10.2.7)
- Upgrading drupal/entity_print (2.13.0 => 2.14.0)
- Upgrading drupal/google_tag (2.0.4 => 2.0.5)
- Upgrading drupal/jquery_ui (1.6.0 => 1.7.0)
- Upgrading drupal/jquery_ui_datepicker (2.0.0 => 2.1.0)
- Upgrading drupal/jquery_ui_slider (2.0.0 => 2.1.0)
- Upgrading drupal/jquery_ui_touch_punch (1.1.0 => 1.1.1)
- Locking drupal/js_cookie (1.0.1)
- Upgrading drupal/key (1.17.0 => 1.18.0)
- Upgrading drupal/tfa (1.6.0 => 1.7.0)
- Upgrading drupal/upgrade_status (4.2.0 => 4.3.2)
- Upgrading drupal/views_bulk_operations (4.2.6 => 4.2.7)
- Upgrading drush/drush (12.5.1 => 12.5.2)
- Upgrading grasmash/yaml-cli (3.2.0 => 3.2.1)
- Upgrading league/csv (9.15.0 => 9.16.0)
- Upgrading mglaman/phpstan-drupal (1.2.10 => 1.2.11)
- Upgrading onelogin/php-saml (4.1.0 => 4.2.0)
- Upgrading paragonie/constant_time_encoding (v2.6.3 => v2.7.0)
- Upgrading phpstan/extension-installer (1.3.1 => 1.4.1)
- Upgrading phpstan/phpstan (1.10.67 => 1.11.4)
- Upgrading phpstan/phpstan-deprecation-rules (1.1.4 => 1.2.0)
- Upgrading phpstan/phpstan-phpunit (1.3.16 => 1.4.0)
- Locking phrity/net-stream (1.3.0)
- Locking phrity/net-uri (1.3.0)
- Locking phrity/util-errorhandler (1.1.0)
- Locking phrity/websocket (1.7.3)
- Upgrading psy/psysh (v0.12.3 => v0.12.4)
- Upgrading react/promise (v3.1.0 => v3.2.0)
- Upgrading squizlabs/php_codesniffer (3.9.1 => 3.10.1)
- Upgrading symfony/browser-kit (v6.4.3 => v6.4.8)
- Upgrading symfony/config (v6.4.6 => v6.4.8)
- Upgrading symfony/css-selector (v6.4.3 => v6.4.8)
- Upgrading symfony/dom-crawler (v6.4.4 => v6.4.8)
- Upgrading symfony/http-client (v6.4.6 => v6.4.8)
- Upgrading symfony/lock (v6.4.6 => v6.4.8)
- Upgrading symfony/phpunit-bridge (v6.4.6 => v6.4.8)
- Upgrading symfony/translation (v6.4.4 => v6.4.8)
- Upgrading webflo/drupal-finder (1.2.2 => 1.3.0)
Installing dependencies from lock file (including require-dev)
Package operations: 7 installs, 45 updates, 3 removals
- Removing textalk/websocket (1.5.8)
- Removing phenx/php-svg-lib (0.5.4)
- Removing phenx/php-font-lib (0.5.6)
- Upgrading phpstan/phpstan (1.10.67 => 1.11.4)
- Upgrading phpstan/extension-installer (1.3.1 => 1.4.1)
- Upgrading symfony/http-client (v6.4.6 => v6.4.8)
- Upgrading symfony/dom-crawler (v6.4.4 => v6.4.8)
- Upgrading symfony/css-selector (v6.4.3 => v6.4.8)
- Upgrading symfony/browser-kit (v6.4.3 => v6.4.8)
- Upgrading composer/pcre (3.1.3 => 3.1.4)
- Upgrading composer/class-map-generator (1.1.1 => 1.3.3)
- Upgrading composer/xdebug-handler (3.0.4 => 3.0.5)
- Upgrading symfony/config (v6.4.6 => v6.4.8)
- Upgrading symfony/translation (v6.4.4 => v6.4.8)
- Installing phrity/util-errorhandler (1.1.0)
- Installing phrity/net-uri (1.3.0)
- Installing phrity/net-stream (1.3.0)
- Installing phrity/websocket (1.7.3)
- Upgrading dmore/chrome-mink-driver (2.9.2 => 2.9.3)
- Upgrading doctrine/event-manager (2.0.0 => 2.0.1)
- Installing dompdf/php-font-lib (1.0.0)
- Installing dompdf/php-svg-lib (1.0.0)
- Upgrading webflo/drupal-finder (1.2.2 => 1.3.0)
- Upgrading drevops/behat-steps (2.2.0 => 2.3.0)
- Upgrading drupal/jquery_ui (1.6.0 => 1.7.0)
- Upgrading drupal/jquery_ui_touch_punch (1.1.0 => 1.1.1)
- Upgrading drupal/jquery_ui_slider (2.0.0 => 2.1.0)
- Upgrading drupal/jquery_ui_datepicker (2.0.0 => 2.1.0)
- Upgrading drupal/better_exposed_filters (6.0.3 => 6.0.6)
- Installing drupal/js_cookie (1.0.1)
- Upgrading drupal/collapsiblock (4.1.0 => 4.2.0)
- Upgrading symfony/phpunit-bridge (v6.4.6 => v6.4.8)
- Upgrading symfony/lock (v6.4.6 => v6.4.8)
- Upgrading phpstan/phpstan-phpunit (1.3.16 => 1.4.0)
- Upgrading phpstan/phpstan-deprecation-rules (1.1.4 => 1.2.0)
- Upgrading mglaman/phpstan-drupal (1.2.10 => 1.2.11)
- Upgrading squizlabs/php_codesniffer (3.9.1 => 3.10.1)
- Upgrading drupal/coder (8.3.23 => 8.3.24)
- Upgrading react/promise (v3.1.0 => v3.2.0)
- Upgrading composer/composer (2.7.2 => 2.7.7)
- Upgrading drupal/core-dev (10.2.5 => 10.2.7)
- Upgrading dompdf/dompdf (v2.0.7 => v3.0.0)
- Upgrading drupal/entity_print (2.13.0 => 2.14.0)
- Upgrading drupal/google_tag (2.0.4 => 2.0.5)
- Upgrading drupal/key (1.17.0 => 1.18.0)
- Upgrading psy/psysh (v0.12.3 => v0.12.4)
- Upgrading grasmash/yaml-cli (3.2.0 => 3.2.1)
- Upgrading chi-teck/drupal-code-generator (3.5.0 => 3.6.0)
- Upgrading drush/drush (12.5.1 => 12.5.2)
- Upgrading onelogin/php-saml (4.1.0 => 4.2.0)
- Upgrading paragonie/constant_time_encoding (v2.6.3 => v2.7.0)
- Upgrading drupal/tfa (1.6.0 => 1.7.0)
- Upgrading drupal/upgrade_status (4.2.0 => 4.3.2)
- Upgrading drupal/views_bulk_operations (4.2.6 => 4.2.7)
- Upgrading league/csv (9.15.0 => 9.16.0)
I tried applied the diff as a patch. It applied cleanly to 3.1.33 but it did not work for me. Still seeing the error. FWIW I am not using the chosen module. I am using the Autocomplete (Tag style) widget.
Full js error output
bundle.js?v=10.2.6:8 Uncaught TypeError: this[{(intermediate value)(intermediate value)(intermediate value)}[r]] is not a function
at u.computeTids (bundle.js?v=10.2.6:8:10308)
at n (bundle.js?v=10.2.6:1:101244)
at HTMLInputElement. (bundle.js?v=10.2.6:1:101687)
at HTMLInputElement.dispatch (jquery.min.js?v=3.7.1:2:40035)
at v.handle (jquery.min.js?v=3.7.1:2:38006)
u.computeTids @ bundle.js?v=10.2.6:8
n @ bundle.js?v=10.2.6:1
(anonymous) @ bundle.js?v=10.2.6:1
dispatch @ jquery.min.js?v=3.7.1:2
v.handle @ jquery.min.js?v=3.7.1:2
bundle.js?v=10.2.6:8 Uncaught TypeError: this[{(intermediate value)(intermediate value)(intermediate value)}[r]] is not a function
at u.computeTids (bundle.js?v=10.2.6:8:10308)
at n (bundle.js?v=10.2.6:1:101244)
at HTMLInputElement. (bundle.js?v=10.2.6:1:101687)
at HTMLInputElement.dispatch (jquery.min.js?v=3.7.1:2:40035)
at v.handle (jquery.min.js?v=3.7.1:2:38006)
u.computeTids @ bundle.js?v=10.2.6:8
n @ bundle.js?v=10.2.6:1
(anonymous) @ bundle.js?v=10.2.6:1
dispatch @ jquery.min.js?v=3.7.1:2
v.handle @ jquery.min.js?v=3.7.1:2
bundle.js?v=10.2.6:8 Uncaught TypeError: this[{(intermediate value)(intermediate value)(intermediate value)}[r]] is not a function
at u.computeTids (bundle.js?v=10.2.6:8:10308)
at n (bundle.js?v=10.2.6:1:101244)
at HTMLInputElement. (bundle.js?v=10.2.6:1:101687)
at HTMLInputElement.dispatch (jquery.min.js?v=3.7.1:2:40035)
at v.handle (jquery.min.js?v=3.7.1:2:38006)
u.computeTids @ bundle.js?v=10.2.6:8
n @ bundle.js?v=10.2.6:1
(anonymous) @ bundle.js?v=10.2.6:1
dispatch @ jquery.min.js?v=3.7.1:2
v.handle @ jquery.min.js?v=3.7.1:2
I encountered this error while the autocomplete is being populated with text.
The error does not happen with core 10.2.5 installed.
I only see it when I update to 10.2.6.
It looks like the screenshot from someshver β also shows the version at 10.2.6 https://www.drupal.org/files/issues/2024-05-13/Untitled.png β
Patch in #14 Does not apply cleanly on 10.1
Here is an updated patch that fixes the error on the node edit page. Seems like the function loadTemplate() NodeEntityBundleInfo.php line 89 should be removed/replaced as it is marked @internal. However this change seems to work.
After applying the patch I am seeing this error on the node edit page:
The website encountered an unexpected error. Please try again later.
ArgumentCountError: Too few arguments to function Twig\Environment::loadTemplate(), 1 passed in /opt/drupal/web/web/modules/contrib/permissions_by_term/src/Service/NodeEntityBundleInfo.php on line 89 and at least 2 expected in Twig\Environment->loadTemplate() (line 330 of /opt/drupal/web/vendor/twig/twig/src/Environment.php).
Drupal\permissions_by_term\Service\NodeEntityBundleInfo->renderNodeDetails('modules/contrib/permissions_by_term/src/View/node-details.html.twig', 'en', '899') (Line: 353)
permissions_by_term_form_alter(Array, Object, 'node_result_edit_form') (Line: 545)
Drupal\Core\Extension\ModuleHandler->alter('form', Array, Object, 'node_result_edit_form') (Line: 838)
Drupal\Core\Form\FormBuilder->prepareForm('node_result_edit_form', Array, Object) (Line: 282)
Drupal\Core\Form\FormBuilder->buildForm(Object, Object) (Line: 73)
Drupal\Core\Controller\FormController->getContentResult(Object, Object) (Line: 39)
Drupal\layout_builder\Controller\LayoutBuilderHtmlEntityFormController->getContentResult(Object, Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 580)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 163)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 74)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 686)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)
Running 10.0.7
I get this error https://www.drupal.org/project/permissions_by_term/issues/3289053#commen... π Automated Drupal 10 compatibility fixes for Permissions by Term Fixed
Notice that the code in the git repo is NOT that code that ends up in the project prior to the patch being applied.
This is the git repo code https://git.drupalcode.org/project/permissions_by_term/-/blob/3.1.21/per...
name: 'Permissions by Term'
description: 'Restricts access to nodes and taxonomy terms via user to term relations.'
dependencies:
- 'drupal:system'
- 'drupal:field'
- 'drupal:taxonomy'
- 'drupal:path_alias'
type: module
core_version_requirement: '^9'
version: '3.1.9'
package: 'Permissions by Term'
configure: permissions_by_term.settings
This is what the patch is trying to apply against https://www.drupal.org/project/permissions_by_term/issues/3289053#commen... π Automated Drupal 10 compatibility fixes for Permissions by Term Fixed
name: 'Permissions by Term'
description: 'Restricts access to nodes and taxonomy terms via user to term relations.'
dependencies:
- 'drupal:system'
- 'drupal:field'
- 'drupal:taxonomy'
- 'drupal:path_alias'
type: module
core_version_requirement: '^9'
# version: '3.1.9'
package: 'Permissions by Term'
configure: permissions_by_term.settings
# Information added by Drupal.org packaging script on 2022-11-09
version: '3.1.21'
project: 'permissions_by_term'
datestamp: 1668009537
Read this issue for a better understanding https://www.drupal.org/project/drupal/issues/3036459 π Packaging info from .info.yml often creates conflicts when patching Active
This patch looks to have trouble applying because the packing script alters the info file. Likely this issue : https://www.drupal.org/project/drupal/issues/3036459 π Packaging info from .info.yml often creates conflicts when patching Active
I was able to work around it and get the patch to apply cleanly with this
"config": {
"preferred-install": {
"drupal/permissions_by_term": "source",
"*": "auto"
},
https://www.drupal.org/project/drupal/issues/3036459#comment-13851631
π
Packaging info from .info.yml often creates conflicts when patching
Active
https://getcomposer.org/doc/06-config.md#preferred-install
3.1.21 does looks like it only has ^9 not ^10
https://git.drupalcode.org/project/permissions_by_term/-/blob/3.1.21/per...