I've added a needs-maintainer-reply tag to this, hopefully a core maintainer can take a look and advise, since this is so helpful and has been around for so long and was passing tests, and needs a helping hand...
I've flipped this to RTBC, because, I believe it is. (Yes, it works for me under 7.39 also)
Confirmed #231 for D7.36 (I had been using the prior patch; this one also works.)
This patch worked for me!
My use-case: I had a View that was supposed to use a non-required relationship-provided field as a filter, ORed with some other filter conditions on fields that didn't share the relationship. Nothing that wasn't in the relationship was showing up.
Patch fixed it, and no side-effects that I can tell. Thanks!
It sounds like the postgre SQL problem is fixed, and there are quite a few reviews of the patch here saying it worked. What else do we need to get this committed to the next release? Is there an error in the test but not the patch?