Amman, Jordan
Account created on 29 June 2011, over 13 years ago
#

Merge Requests

Recent comments

πŸ‡―πŸ‡΄Jordan Yasser Samman Amman, Jordan

#3 applies cleanly on Drupal 10.3.3, works fine, thanks andre.bonon.
The issue status should be set to Needs Review, as it is not fixed in the release.

πŸ‡―πŸ‡΄Jordan Yasser Samman Amman, Jordan

Great! Thanks @andrei.vesterli
I'll make sure to test it ASAP.

πŸ‡―πŸ‡΄Jordan Yasser Samman Amman, Jordan

I think this is an important feature to have. Is there anything remaining for this to be merged ?

πŸ‡―πŸ‡΄Jordan Yasser Samman Amman, Jordan

Yasser Samman β†’ made their first commit to this issue’s fork.

πŸ‡―πŸ‡΄Jordan Yasser Samman Amman, Jordan

Added MR#4
I think the same should be done to the list store country resource too.

πŸ‡―πŸ‡΄Jordan Yasser Samman Amman, Jordan

Thanks beunerd!
Just added an initialization for $all in RouteSubscriberTagAllRoutes to avoid errors on cache rebuilds and when enabling the module.
So far it is working fine.

πŸ‡―πŸ‡΄Jordan Yasser Samman Amman, Jordan

Test failed because of wrong arguments in CheckoutCartEventSubscriber.
Here's another try.

πŸ‡―πŸ‡΄Jordan Yasser Samman Amman, Jordan

I had to re-roll #152 to latest dev and test on 2.36.

πŸ‡―πŸ‡΄Jordan Yasser Samman Amman, Jordan

#6 looks good.
Tried it on a LottieFiles JSON file and worked like a charm.
RTBC

Production build 0.71.5 2024