No JavaScript errors or network issues were observed in developer tools
That got me wondering... If I turn off Javascript in Firefox and then visit the node form, click "Preview", then use the browser's back button, the action buttons retain their functionality.
On a whim, I've also tried turning off CSS and JS aggregation. Doing so doesn't seem to fix anything. Doesn't hurt to try.
That's awesome. Thank you for that.
I removed my hook_form_alter and gave commit abce0b5f a quick run through and the Save button appears first and is the default submit button when adding and editing nodes.
Looks good to me.
ulethjay → created an issue.
Wow that was fast.
I forgot to mention why I even brought this up in the first place.
We're a University with ~200 users able to add / edit content. Naturally their familiarity, comfort level, technical prowess, etc. varies wildly. We've asked a number of these users to kick the tires on the D10 replacement we've been working on.
We had a couple users report that their changes weren't being saved. When we watched one of them edit a node title and press "Enter" they were brought to the preview page. This user had no idea that is was a preview page and just assumed that their edit would have been saved, because in their mind that's how things work in D7. And as far as I know, the default in D10 also is to Save.
Anyways…
Personally, I'm fine with the ticket being closed. I'm in the fortunate position of not needing to worry about how a change here might effect the users of the other 55,000 sites gin has been installed on and have swapped the behaviour back with a hook_form_alter.
Thanks for your time.
ulethjay → created an issue.
ulethjay → created an issue.
ulethjay → created an issue.
ulethjay → created an issue.
Well... here's my take on a patch. Rather than simply removing one or the other, I went with checking the local menu for duplicate "Revisions" tabs and removing all but the first.
In theory it could be applied to any past or future version of Drupal or Group, and not do anything silly. Though I've only tried it on Drupal 10.1 and Group 3.2.x
For what it's worth; I upgraded from d9 to d10 on Lando with the drupal9 recipe. CSS/JS Aggregation was borked until I thought to rebuild using the drupal10 recipe.
name: funky-site-name
recipe: drupal10
config:
php: 8.1
webroot: web
via: nginx
...