I tested the patch, it works as expected.
Because I'm rather new to this, documenting the steps I took to test the patch.
Note in particular the `composer create-project` command to install the head of the drupal-cms repo, thank you to phenaproxima for this tip in the #drupal-cms-development channel on drupal slack.
mkdir eca-3501241
cd eca-3501241
ddev config
ddev start
ddev composer create-project drupal/cms:1.x-dev -s dev
ddev drush site:install --yes
ddev launch $(ddev drush uli)
By default, the "Privacy policy" page is unpublished.
Without the model in place, https://eca-3501241.ddev.site/privacy-policy returns a 404.
So, now let's import the model from @jurgenhaas comment #6.
mkdir -p web/tmp
# Paste the yaml from @jurgenhaas #6 comment
nvim web/tmp/eca.eca.unpublished_404.yml
# Import the single configuration file
ddev drush config:import --partial --source=tmp
That worked. For an anonymous user, https://eca-3501241.ddev.site/privacy-policy now returns a 404.
michaellenahan ā created an issue.
mradcliffe ā credited michaellenahan ā .
michaellenahan ā created an issue. See original summary ā .
@brayn7 - #13 #14 worked for me, thank you
By the way @mxh I would be happy to become a maintainer if that helps you. I don't think many people are actively using this module, but we are (still).
Re-opening this issue, because there is a syntax error in the patch.
Instead of this:
if is_array($instance->zoneId) {
... we should have this ...
if (is_array($instance->zoneId)) {
Here is the updated patch to be applied on top of 1.0.x-dev
Hi mxh and thanks!
Okay - Iām not sure why Iām getting a string value here, need to investigate further at my end.
Meantime feel free to close as wontfix, the issue will still be here in case anyone else gets the same error, then they can comment and reopen.
Here is the patch.
michaellenahan ā created an issue.
lostcarpark ā credited michaellenahan ā .
John Cook ā credited michaellenahan ā .
John Cook ā credited michaellenahan ā .
John Cook ā credited michaellenahan ā .
John Cook ā credited michaellenahan ā .
michaellenahan ā created an issue.
volkswagenchick ā credited michaellenahan ā .
Removed novice tag because not a straightforward drupal 11 fix.
We, the mentoring team, are triaging issues for first time contributors at DrupalCon Lille and I think this is a good issue for the contribution day.
We are reserving this issue so please don't work on this issue if you are not at DrupalCon Lille. You can continue the work when the event is over.
We, the mentoring team, are triaging issues for first time contributors at DrupalCon Lille and I think this is a good issue for the contribution day.
We are reserving this issue so please don't work on this issue if you are not at DrupalCon Lille. You can continue the work when the event is over.
Sorry for the noise. Here is the patch for drupal 10, including the changes from here: https://www.drupal.org/project/social_share/issues/3378493 š [error] Error: Class "Drupal\Core\Plugin\ContextAwarePluginBase" not found in include() (line 44 of modules/contrib/social_share/src/Plugin/SocialShareLink/LInkedInShareLink.php) Needs review
#22 patch was incomplete, here is the correct patch.
This patch provides drupal 10 compatability, following on from https://www.drupal.org/project/social_share/issues/3378493 š [error] Error: Class "Drupal\Core\Plugin\ContextAwarePluginBase" not found in include() (line 44 of modules/contrib/social_share/src/Plugin/SocialShareLink/LInkedInShareLink.php) Needs review
Looks like this is a duplicate of https://www.drupal.org/project/advagg/issues/3124130 š Optimized js assets fed into _locale_parse_js_file Needs work
michaellenahan ā created an issue.
michaellenahan ā created an issue.