🇩🇪Germany @michaellenahan

By the way @mxh I would be happy to become a maintainer if that helps you. I don't think many people are actively using this module, but we are (still).

Re-opening this issue, because there is a syntax error in the patch.

Instead of this:

if is_array($instance->zoneId) {

... we should have this ...

if (is_array($instance->zoneId)) {

Here is the updated patch to be applied on top of 1.0.x-dev

Hi mxh and thanks!

Okay - I’m not sure why I’m getting a string value here, need to investigate further at my end.

Meantime feel free to close as wontfix, the issue will still be here in case anyone else gets the same error, then they can comment and reopen.

Here is the patch.

michaellenahan → created an issue.

lostcarpark → credited michaellenahan → .

John Cook → credited michaellenahan → .

John Cook → credited michaellenahan → .

John Cook → credited michaellenahan → .

John Cook → credited michaellenahan → .

michaellenahan → created an issue.

volkswagenchick → credited michaellenahan → .

Removed novice tag because not a straightforward drupal 11 fix.

We, the mentoring team, are triaging issues for first time contributors at DrupalCon Lille and I think this is a good issue for the contribution day.
We are reserving this issue so please don't work on this issue if you are not at DrupalCon Lille. You can continue the work when the event is over.

We, the mentoring team, are triaging issues for first time contributors at DrupalCon Lille and I think this is a good issue for the contribution day.
We are reserving this issue so please don't work on this issue if you are not at DrupalCon Lille. You can continue the work when the event is over.

Sorry for the noise. Here is the patch for drupal 10, including the changes from here: https://www.drupal.org/project/social_share/issues/3378493 🐛 [error] Error: Class "Drupal\Core\Plugin\ContextAwarePluginBase" not found in include() (line 44 of modules/contrib/social_share/src/Plugin/SocialShareLink/LInkedInShareLink.php) Needs review

#22 patch was incomplete, here is the correct patch.

This patch provides drupal 10 compatability, following on from https://www.drupal.org/project/social_share/issues/3378493 🐛 [error] Error: Class "Drupal\Core\Plugin\ContextAwarePluginBase" not found in include() (line 44 of modules/contrib/social_share/src/Plugin/SocialShareLink/LInkedInShareLink.php) Needs review

Looks like this is a duplicate of https://www.drupal.org/project/advagg/issues/3124130 🐛 Optimized js assets fed into _locale_parse_js_file Needs work

michaellenahan → created an issue.

michaellenahan → created an issue.