There's no special reason for me naming the hook with "facet" instead of "facets". If a patch with "facets" better conforms to coding conventions, here's an updated patch.
Hi @axelm, as I explained in my previous comment, the opingo_module module is not installed and that there are 2 problems with this:
1) The opingo_module module is not listed as a dependency of the opigno_scorm module 3.1.x in opigno_scorm.info.yml. However, code in the opigno_scorm module requires PHP classes defined by the opigno_module module. I can add the opigno_module, but it should probably be listed as a dependency in the opigno_scorm module's .info.yml file. However, when enabling the opigno_module module, we learn about the other problem:
2) Enabling the opigno_module module requires installing 4 other modules: h5p, pdf, opigno_group_manager, and opigno_skills_system. I'm just trying to render a SCORM file. Do I really need to add these other modules to my site just to render a SCORM file? Do they also provide functionality necessary to rendering SCORM files? If not, it feels like, architecturally, there should be a cleaner separation of the code of these modules and their inter-dependencies.
I'm experiencing the same issue when trying to upgrade from opigno_scorm 3.0.3 to opigno_scorm 3.1.0.
The missing trait referenced in the error message (Drupal\opigno_module\Traits\UnsafeFileValidation) is only defined in the separate opigno_module module, version 3.1.0 which would suggest that opigno_module 3.1.0 is a dependency that is not declared for opigno_scorm module 3.1.0 in opigno_scorm's .info.yml file. However, the opigno_module module itself has a dependency on 4 other modules which I'm not interested in installing.
Are the 3.0.x versions on a different branch from the 3.1.x versions? They both seem to come off of the 3.x branch. Will there be other 3.0.x releases that do NOT require opigno_module and its dependencies or will future updates beyond 3.0.3 require the installation of opigno_module and its dependencies?