πŸ‡ΊπŸ‡ΈUnited States @knaffles

Account created on 28 January 2011, over 13 years ago
#

Merge Requests

Recent comments

πŸ‡ΊπŸ‡ΈUnited States knaffles

@ fraserthompson - Thanks for your work fixing those event listeners. I made one additional change so that `isOpen` is set to true if/when the user opens the mobile menu by clicking the mobile toggle button. Otherwise, the clicks/focus outside of the menu only result in a closure on mobile if one of the submenus has already been opened.

πŸ‡ΊπŸ‡ΈUnited States knaffles

knaffles β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States knaffles

Didn't get a reply from the original reporter, but I'm assuming the issue is due to the fact that they had more than one mega menu on the same page, with each associated with the same Drupal menu. The result is that each menu has the same `id` attribute on the front end which messes up the initialization of the menus. The merge request below fixes the issue by generating a unique uuid for each mega menu. In the process, I fixed a related issue on mobile where a single button to trigger the open/close of a menu was opening/closing all mega menus on the page at the same time.

https://git.drupalcode.org/project/tb_megamenu/-/merge_requests/87

πŸ‡ΊπŸ‡ΈUnited States knaffles

knaffles β†’ changed the visibility of the branch 3369065-sub-navigation-doesnt-show to hidden.

πŸ‡ΊπŸ‡ΈUnited States knaffles

@mambrus - Just to clarify, are you placing two instances (blocks) of the same mega menu on the page? I can see how this is an issue in that scenario, but from your description it's not necessarily clear that that's what you're doing. If only one instance of a menu is placed on the page, I only see one element in the markup with that particular ID and it doesn't appear to be an issue.

Production build 0.69.0 2024