@bradjones1
Thanks for the MR, however I'm curious how you handle the empty case? It seems to require special handling, unless I'm missing something obvious here.
Can you elaborate on why empty field item lists need special handling, i seem to be missing or not fully grasping something on that front?
Interested in thought, feedback, anything :-)
jan.stoeckler → created an issue.
Another attempt with a slightly different approach which might not need an additional interface for empty field item lists, let's see how it goes.
Would appreciate some review, but leaving at 'needs work' due to missing test coverage.
jan.stoeckler → made their first commit to this issue’s fork.
Added a small fix to __flysystem_check_dependencies to account for updated dependencies.
Hey folks,
this is an attempt to port the flysystem.module to Flysystem v2/3 API with as little architectural changes to the module as possible, so basically foregoing the refactoring mentioned in the issue summary as a first step to get something working. Local and FTP adapters are working on my end, as well as the DrupalCacheAdapter. I have not touched any tests yet, so those are very likely to fail.
In case anyone wants to try this out, and/or needs a working S3 integration, there's also an example provider module using the AsyncAws S3 Adapter attached: https://www.drupal.org/files/issues/2023-06-22/flysystem_asyncawss3.zip → .
Would appreciate any feedback and/or guidance on if and how to proceed further. Thanks!
Something that does not yet seem to work correctly: removing items after having changed their order (without saving in between) - this probably needs to be addressed.
1. Is get_class($this) necessary? Or will $this suffice?
I'm not sure, both seem to work, as well as static::class - don't have a preference & will implement whatever's most appropriate.
2. This seems like it might be cause of the test failures. Why -4?
As far as I can tell, we use -4 here to get "up" in the nested array from the triggered submit element to its field element to replace its previous state with it (the whole field element).
Addresses/(hopefully) fixes some of the test failures.
Reroll & small tweaks; AJAX-callback should work now. Can't figure out how to generate an interdiff as patch file from #166 doesn't seem to apply.