🇮🇳India @hemant-gupta

It's compatible with Drupal 11 now.

I have used it but not not working for anonymous users!

The same issue has been noticed, please update here if any solution worked.

It works as checked.

Thanks for your review! @trigve-hagen
Also, your points are closed in DEV branch.

License file is added again! @apaderno

Thanks for your feedback, @andrei.vesterli!

All suggested points have been addressed accordingly.

It's corrected, thanks!

Lazy builder added now. Let me know if further improvements needed.

Yes, I got your point and tried the same as they did in example but the module BigPipe does not support any more for the later version of Drupal 8 and that's why JS snippet covers this gap.

Thanks for your feedback!

Actually, this is a time centric module and if we use formats from 'admin/config/regional/date-time' then many date formats of them doesn't have a time to show and all these formats are freely managed in back-end on admin preference so I preferred like this way. Also, the block does not 'suffer' from caching to show us an updated content.

Suggested points has been corrected, let me know if still any thing found.

I have removed the form class and implemented "BlockPluginInterface" for the block settings now, please check.

OK, thanks for valuable info.

I have used a block built only to make its data available to users and not implemented the form block as not needed, kindly recheck this.

Thanks for your review @nikral!

I have changed the codes accordingly in DEV, please see.

Yes, I have used Drupal library for testing and the actual errors were from line no. 63-131 as mentioned which you tried to fix.

Ignore this 'Non-namespaced classes/interfaces/traits should not be referenced with use statements' as no coding standards fault.

Other findings to fix-

FILE: field_extra/field_extra.module
---------------------------------------------------------------------------------------------------------
FOUND 15 ERRORS AFFECTING 5 LINES
---------------------------------------------------------------------------------------------------------
1 | ERROR | [x] Non-namespaced classes/interfaces/traits should not be referenced with use statements
1 | ERROR | [x] Non-namespaced classes/interfaces/traits should not be referenced with use statements
1 | ERROR | [x] Non-namespaced classes/interfaces/traits should not be referenced with use statements
1 | ERROR | [x] Non-namespaced classes/interfaces/traits should not be referenced with use statements
1 | ERROR | [x] Non-namespaced classes/interfaces/traits should not be referenced with use statements
1 | ERROR | [x] Non-namespaced classes/interfaces/traits should not be referenced with use statements
1 | ERROR | [x] Non-namespaced classes/interfaces/traits should not be referenced with use statements
1 | ERROR | [x] Non-namespaced classes/interfaces/traits should not be referenced with use statements
1 | ERROR | [x] Non-namespaced classes/interfaces/traits should not be referenced with use statements
63 | ERROR | [ ] If there is no return value for a function, there must not be a @return tag.
63 | ERROR | [ ] Description for the @return value is missing
65 | ERROR | [ ] Type hint "array" missing for $form
129 | ERROR | [ ] If there is no return value for a function, there must not be a @return tag.
129 | ERROR | [ ] Description for the @return value is missing
131 | ERROR | [ ] Type hint "array" missing for $form
---------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------
Time: 67ms; Memory: 8MB

Look into this-

FILE: media_popup/media_popup.module
-------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line
1 | ERROR | [x] Non-namespaced classes/interfaces/traits should not be referenced with use statements
-------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------
Time: 46ms; Memory: 6MB

In project file "comment_on_top.info.yml", the key core_version_requirement cannot be used to restrict to core version before 8.7.7 and it would throw a parsing exception.

So, you need to replace that with "core_version_requirement to ^8.8 || ^9 || ^10" to fix.

Source- https://www.drupal.org/docs/develop/creating-modules/let-drupal-know-abo... →

hemant-gupta → created an issue.

Yes, the branch needs to be updated first for every change review before a release.

Thanks for your feedback!

OK, thanks!

Initial settings added, thanks for your feedback!

Thanks for your feedback!

Actually, this is a time centric module and if we use formats from 'admin/config/regional/date-time' then many date formats of them does not have a time format to show the current time and also all these formats are added/managed by back-end so I preferred like this way.

Thanks for feedback!

It's fixed now and no "project", "datestamp" or "version" key is present in the info.yml as the log shows. May be You tried to check the downloaded version on your disk, this doesn't check the code in the repository so you can close it.

It's fixed.

Issues fixed as suggested by PHPCS.

It was fixed by the patches.

Fixed with the later release.