- π¬π§United Kingdom catch
OK I found various problems in both MRs, some of the changes were fine, some not:
1. The MRs should patch vendor/ because that's not part of the module.
2. Aggregation changes were just switching to a new class instead of updating the actual logic to work. π Refactor asset aggregation to avoid using deprecated asset optimization classes Active is in now, but it needs a further follow-up to clean things up.
Everything else seems mostly OK though. Going to go ahead and merge this into dev, any remaining issues can be handled in separate issues/MRs.
This needs more testing on both 10.x and 11.x before I'd feel comfortable tagging a new release.
- @catch opened merge request.
- π¬π§United Kingdom catch
I've committed a minimal fix on π Refactor asset aggregation to avoid using deprecated asset optimization classes Active , however there are multiple competing MRs here and none of them look ready to commit.