- ๐จ๐ฆCanada joseph.olstad
@brittany-willis, I've spent a lot of time fixing various issues with this module. For this reason before you evaluate anything with this module I highly recommend having a look at applying my merge request that fixes various bugs (likely more than advertised) as well as adds new functionality.
โจ Book TOC (Table of Contents) Active
- ๐บ๐ธUnited States thejimbirch Cape Cod, Massachusetts
@mherchel What do you think of the approach in:
https://developer.mozilla.org/en-US/blog/html-details-exclusive-accordions/
If not, I believe this is going to need JavaScript to work.
- ๐บ๐ธUnited States phenaproxima Massachusetts
Thanks @vasantha deepika! For future reference, if you'd like someone else to review your work, please change the issue status to "Needs review" -- that'll ensure that other eyes get on it. :)
- ๐ฎ๐ณIndia vasantha deepika Coimbatore
Thank you for the new design update! I have updated the MR based on the new design. Additionally, @mherchel, I have used the element for the accordion.
- ๐ฆ๐บAustralia pameeela
Added the design to the IS, note that I've removed the CTA link because this won't work well in XB currently, with the restricted width that we have. So for simplicity let's leave it out for now.
Pushed up what I had to a new branch here: feature/1.x-accordion-component
- ๐บ๐ธUnited States mherchel Gainesville, FL, US
@grifstuf was working on this at FLDC (see the first comment). I know he had code written, but not sure why it's not pushed.
- ๐ฎ๐ณIndia vasantha deepika Coimbatore
Thanks for the feedback Jim Birch!
Iโll review the approach using the element and update the component accordingly. - ๐บ๐ธUnited States thejimbirch Cape Cod, Massachusetts
Using the html element will negate the need for JavaScript to make the accordion work.
Here is a good blog about it.
https://developer.mozilla.org/en-US/blog/html-details-exclusive-accordions/
I assume there is some kind of component is that could be used for the unique name.
- ๐ฎ๐ณIndia vasantha deepika Coimbatore
I have created the Accordion component, but a few improvements are still needed. I am actively working on them.
Please review it and share your suggestions, as they would be very helpful.Thanks!
- @vasantha-deepika opened merge request.
- ๐ฎ๐ณIndia vasantha deepika Coimbatore
vasantha deepika โ made their first commit to this issueโs fork.
- ๐บ๐ธUnited States mherchel Gainesville, FL, US
Should we call this something generic like Accordion
makes sense to me! Updating title