Do not use \Drupal\taxonomy\TermStorageInterface::loadTree() in \Drupal\taxonomy\Form\OverviewTerms::buildForm()

Open on Drupal.org →

Created on 6 April 2010, over 14 years ago

Updated 20 December 2023, 12 months ago

Problem/Motivation

When a vocabulary's term list exceeds an indeterminate amount, users may experience a WSOD → . This is caused by a call to taxonomy_get_tree() from within taxonomy_overview_terms(). This produces a known memory limit issue.

Steps to reproduce the problem:

Install Drupal 8.x with the standard profile.
Install devel.
Visit: Extend (/admin/modules).
Enable Devel and Devel generate modules.
Use Devel to auto-generate terms (/admin/config/development/generate/taxonomy).
Generate for the "tags" vocabulary
Number of terms: 10000.
Browse to terms list for the tags vocabulary (/admin/structure/taxonomy/tags).
Lower PHP memory limits and/or auto-generate more terms, until WSOD occurs in previous step.

Proposed resolution

Disable taxonomy_get_tree() if the vocabulary is over a certain size.
Change term listings from a tree view to a new sibling browser, which requires #698918: Reduce memory usage from \Drupal\taxonomy\TermStorageInterface::loadTree() when parent is specified → .

Remaining tasks

screenshot of the current ui (a before screenshot)
decide what approach to implement

User interface changes

The proposed siblings browser may introduce new or changed features/functionality in the user interface at admin/structure/taxonomy/tags.
Comment #23 has most recent screenshot of taxonomy terms by vocabulary (before proposed siblings browser).

API changes

API changes/additions might be introduced in core's taxonomy module:

Original report by andypost

Vocabulary has hierarchy field with values from 0 to 2.
So overview page for vocabulary should take into accout hierarchy field.

This is a follow up from:
#762604: Taxonomy terms list broken, term add/edit forgets it's parent →
#277200: Add tests for vocabulary hierarchy →

catch:
I really dislike that we use taxonomy_get_tree() in taxonomy_overview_terms()

📌 Task

Status

Postponed

Version

11.0 🔥

Component

Last updated 1 day ago

Maintained by
🇺🇸United States @xjm
🇬🇧United Kingdom @catch

Created by

🇫🇷France andypost

Live updates comments and jobs are added and updated live.

Performance
It affects performance. It is often combined with the Needs profiling tag.

Needs tests
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

DevDaysLisbon

Incomplete comments

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

First commit to issue fork.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,420 pass
@nathandentzau opened merge request.
Comment about 1 year ago →
Amavi
I correct it on my website Drupal 10:

I up the SQL "max_allowed_packet" on my hosting to maximum 64MB and all is oki, it is configured at 1MB basically and too low for Drupal, best ways may be is to write in Tutorial to check this??? I read 8MB is a minimum for Drupal 9....
Comment 12 months ago →
🇮🇳India manojbisht_drupal
Patch 74/75 is not applying for 10.2, so created a new patch for 10.2
Open in Jenkins → Open on Drupal.org →
Environment: PHP 5.3 & MySQL 5.5
last update 12 months ago
Composer error. Unable to continue.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MariaDB 10.3.22
last update 12 months ago
Custom Commands Failed
Status changed to Postponed 12 months ago8:16pm 20 December 2023
Comment 12 months ago →
🇬🇧United Kingdom catch
I think this is a duplicate of (or technically duplicated by, since the other issue is newer than this even though it's also a decade old) 🐛 Avoid loading all terms on the taxonomy overview form Needs work .

Postponing on that issue given it's RTBC.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024