- 🇺🇸United States tr Cascadia
@hargobind: Can you convert your patch into a MR? Drupal.org does not run testing on patches any more - all contributions are expected to be through merge releases.
- 🇺🇸United States hargobind Austin, Texas
@TR: There you go.
Thanks to pipeline tests, I found a PHP 8.2 bug in the new code. All tests are passing now.
This was my first time using gitlab's MR. (I didn't realize the community switched away from the patch-based approach in the last few years.) Let me know if I missed anything.
- 🇺🇸United States hargobind Austin, Texas
Question: on the MR, there is an option "Delete source branch when merge request is accepted."
I want to make sure I'm correct in understanding that source branch = MR/feature branch, and destination branch = the 7.x-2.x branch... right?
Am I correct that checking it means that once the MR is merged, the feature branch I created for this MR will be deleted?
- 🇺🇸United States jacob.embree
That is correct, @hargobind, the feature branch you created would be deleted when the MR is accepted if you checked that box.
- 🇺🇸United States tr Cascadia
Question: on the MR, there is an option "Delete source branch when merge request is accepted."
I want to make sure I'm correct in understanding that source branch = MR/feature branch, and target branch = the 7.x-2.x branch... right?
Am I correct that checking it means that once the MR is merged, the feature branch I created for this MR will be deleted?
Yes, that's what it means. But you shouldn't usually have to worry about that - that box is not checked, by default, and it's OK to leave it like that.
I'm not sure why the Drupal administrators set it up that way, and what they have in mind for cleaning up all the old feature branches accumulating on gitlab, but for now I am just going with the default settings.