phpcs says,
FILE: ...lez/web/modules/custom/tr_rulez/rules_scheduler/src/DefaultTaskHandler.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
29 | WARNING | Unused variable $data.
| | (DrupalPractice.CodeAnalysis.VariableAnalysis.UnusedVariable)
--------------------------------------------------------------------------------
FILE: ...es/custom/tr_rulez/rules_scheduler/src/Plugin/RulesAction/ScheduleTask.php
--------------------------------------------------------------------------------
FOUND 3 ERRORS AND 4 WARNINGS AFFECTING 7 LINES
--------------------------------------------------------------------------------
80 | ERROR | Public method name
| | "ScheduleTask::rules_scheduler_action_schedule" is not in
| | lowerCamel format
| | (Drupal.NamingConventions.ValidFunctionName.ScopeNotCamelCaps)
82 | WARNING | Unused variable $component.
| | (DrupalPractice.CodeAnalysis.VariableAnalysis.UnusedVariable)
109 | ERROR | Public method name
| | "ScheduleTask::rules_scheduler_action_schedule_info_alter" is
| | not in lowerCamel format
| | (Drupal.NamingConventions.ValidFunctionName.ScopeNotCamelCaps)
130 | WARNING | Unused variable $info.
| | (DrupalPractice.CodeAnalysis.VariableAnalysis.UnusedVariable)
133 | WARNING | Exceptions should not be translated
| | (DrupalPractice.General.ExceptionT.ExceptionT)
138 | WARNING | Exceptions should not be translated
| | (DrupalPractice.General.ExceptionT.ExceptionT)
155 | ERROR | Public method name
| | "ScheduleTask::rules_scheduler_action_schedule_form_alter" is
| | not in lowerCamel format
| | (Drupal.NamingConventions.ValidFunctionName.ScopeNotCamelCaps)
--------------------------------------------------------------------------------
FILE: .../web/modules/custom/tr_rulez/rules_scheduler/src/Form/ScheduleTaskForm.php
--------------------------------------------------------------------------------
FOUND 8 ERRORS AND 17 WARNINGS AFFECTING 17 LINES
--------------------------------------------------------------------------------
33 | WARNING | [ ] Line exceeds 80 characters; contains 92 characters
| | (Drupal.Files.LineLength.TooLong)
33 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
| | (Drupal.WhiteSpace.ScopeIndent.IncorrectExact)
33 | ERROR | [x] No space found before comment text; expected "// function
| | rules_scheduler_schedule_form($form, &$form_state,
| | $rules_config, $base_path) {" but found "//function
| | rules_scheduler_schedule_form($form, &$form_state,
| | $rules_config, $base_path) {"
| | (Drupal.Commenting.InlineComment.NoSpaceBefore)
33 | ERROR | [x] Inline comments must start with a capital letter
| | (Drupal.Commenting.InlineComment.NotCapital)
33 | ERROR | [x] Inline comments must end in full-stops, exclamation marks,
| | question marks, colons, or closing parentheses
| | (Drupal.Commenting.InlineComment.InvalidEndChar)
34 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 0
| | (Drupal.WhiteSpace.ScopeIndent.IncorrectExact)
36 | WARNING | [ ] Code after the RETURN statement on line 34 cannot be
| | executed (Squiz.PHP.NonExecutableCode.Unreachable)
37 | WARNING | [ ] Code after the RETURN statement on line 34 cannot be
| | executed (Squiz.PHP.NonExecutableCode.Unreachable)
38 | WARNING | [ ] Code after the RETURN statement on line 34 cannot be
| | executed (Squiz.PHP.NonExecutableCode.Unreachable)
40 | WARNING | [ ] Code after the RETURN statement on line 34 cannot be
| | executed (Squiz.PHP.NonExecutableCode.Unreachable)
41 | WARNING | [ ] Code after the RETURN statement on line 34 cannot be
| | executed (Squiz.PHP.NonExecutableCode.Unreachable)
43 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters
| | (Drupal.Files.LineLength.TooLong)
43 | WARNING | [x] There must be no blank line following an inline comment
| | (Drupal.Commenting.InlineComment.SpacingAfter)
43 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 0
| | (Drupal.WhiteSpace.ScopeIndent.IncorrectExact)
43 | ERROR | [x] 6 spaces found before inline comment; expected "// $action
| | = rules_action('schedule', ['component' =>
| | $rules_component->name]);" but found "// $action =
| | rules_action('schedule', ['component' =>
| | $rules_component->name]);"
| | (Drupal.Commenting.InlineComment.SpacingBefore)
45 | WARNING | [ ] Code after the RETURN statement on line 34 cannot be
| | executed (Squiz.PHP.NonExecutableCode.Unreachable)
47 | WARNING | [ ] Code after the RETURN statement on line 34 cannot be
| | executed (Squiz.PHP.NonExecutableCode.Unreachable)
48 | WARNING | [ ] Code after the RETURN statement on line 34 cannot be
| | executed (Squiz.PHP.NonExecutableCode.Unreachable)
49 | WARNING | [ ] Code after the RETURN statement on line 34 cannot be
| | executed (Squiz.PHP.NonExecutableCode.Unreachable)
50 | WARNING | [ ] Code after the RETURN statement on line 34 cannot be
| | executed (Squiz.PHP.NonExecutableCode.Unreachable)
51 | WARNING | [ ] Code after the RETURN statement on line 34 cannot be
| | executed (Squiz.PHP.NonExecutableCode.Unreachable)
52 | WARNING | [x] '@todo $form['#validate'] =
| | ['rules_ui_form_rules_config_validate'];' should match the
| | format '@todo Fix problem X here.'
| | (Drupal.Commenting.TodoComment.TodoFormat)
52 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 0
| | (Drupal.WhiteSpace.ScopeIndent.IncorrectExact)
53 | WARNING | [ ] Code after the RETURN statement on line 34 cannot be
| | executed (Squiz.PHP.NonExecutableCode.Unreachable)
56 | WARNING | [ ] Code after the RETURN statement on line 34 cannot be
| | executed (Squiz.PHP.NonExecutableCode.Unreachable)
--------------------------------------------------------------------------------
see https://git.drupalcode.org/project/tr_rulez/-/jobs/4173990
make a MR
Needs review
2.0
Code
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
No activities found.