phpcs reports,
FILE: src/SAML/SamlSPSettings.php
------------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------------------------
22 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
| | (Generic.WhiteSpace.DisallowTabIndent.TabsUsed)
22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 (Drupal.WhiteSpace.ScopeIndent.IncorrectExact)
50 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
| | (Generic.WhiteSpace.DisallowTabIndent.TabsUsed)
50 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2 (Drupal.WhiteSpace.ScopeIndent.IncorrectExact)
145 | ERROR | [x] Closing brace indented incorrectly; expected 1 spaces, found 2
| | (Drupal.WhiteSpace.ScopeClosingBrace.Indent)
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------
FILE: src/SAML/SamlSPMetadata.php
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
17 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
| | (Generic.PHP.UpperCaseConstant.Found)
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------
FILE: src/Form/SamlSpConfig.php
------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------------------------
38 | ERROR | [ ] Parameter $configFactory is not described in comment
| | (Drupal.Commenting.FunctionComment.ParamMissingDefinition)
38 | ERROR | [ ] Parameter $typedConfigManager is not described in comment
| | (Drupal.Commenting.FunctionComment.ParamMissingDefinition)
179 | ERROR | [x] Expected newline after closing brace
| | (Drupal.ControlStructures.ControlSignature.NewlineAfterCloseBrace)
531 | ERROR | [x] Expected newline after closing brace
| | (Drupal.ControlStructures.ControlSignature.NewlineAfterCloseBrace)
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------
FILE: src/Form/IdpForm.php
---------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------
42 | ERROR | [x] Expected 1 blank line after function; 2 found (Squiz.WhiteSpace.FunctionSpacing.After)
---------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------
FILE: src/Controller/SamlSPController.php
-----------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------
54 | ERROR | [ ] More than 2 empty lines are not allowed (Drupal.WhiteSpace.EmptyLines.EmptyLines)
58 | ERROR | [x] Expected 1 blank line before function; 3 found (Squiz.WhiteSpace.FunctionSpacing.Before)
-----------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------
FILE: saml_sp.module
------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
------------------------------------------------------------------------------------------------------------------------
115 | ERROR | [x] Short array syntax must be used to define arrays (Drupal.Arrays.DisallowLongArraySyntax.Found)
218 | ERROR | [x] Use null coalesce operator instead of ternary operator.
| | (SlevomatCodingStandard.ControlStructures.RequireNullCoalesceOperator.NullCoalesceOperatorNotUsed)
234 | ERROR | [x] Expected "bool" but found "boolean" for parameter type
| | (Drupal.Commenting.FunctionComment.IncorrectParamVarName)
265 | ERROR | [x] Whitespace found at end of line (Squiz.WhiteSpace.SuperfluousWhitespace.EndLine)
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------
FILE: modules/saml_sp_drupal_login/saml_sp_drupal_login.module
------------------------------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AND 4 WARNINGS AFFECTING 14 LINES
------------------------------------------------------------------------------------------------------------------------
139 | ERROR | [ ] The array declaration extends to column 178 (the limit is 120). The array content should be split
| | up over multiple lines (Drupal.Arrays.Array.LongLineDeclaration)
167 | WARNING | [x] 'TODO: Either fail completely here or add tests for email in the' should match the format '@todo
| | Fix problem X here.' (Drupal.Commenting.TodoComment.TodoFormat)
210 | ERROR | [ ] The array declaration extends to column 134 (the limit is 120). The array content should be split
| | up over multiple lines (Drupal.Arrays.Array.LongLineDeclaration)
279 | WARNING | [x] 'TODO: this might not be the right place for this. It doesn't do' should match the format '@todo
| | Fix problem X here.' (Drupal.Commenting.TodoComment.TodoFormat)
306 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 1 spaces
| | (Drupal.Commenting.FunctionComment.ParamCommentIndentation)
307 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 1 spaces
| | (Drupal.Commenting.FunctionComment.ParamCommentIndentation)
308 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 1 spaces
| | (Drupal.Commenting.FunctionComment.ParamCommentIndentation)
347 | ERROR | [x] Expected "mixed|null" but found "mixed|NULL" for parameter type
| | (Drupal.Commenting.FunctionComment.IncorrectParamVarName)
360 | ERROR | [ ] The trigger_error message 'Passing email as a string is deprecated in saml_sp:4.1.0 and will be
| | removed in saml_sp:5.0' does not match the relaxed standard format: %thing% is deprecated in
| | %deprecation-version% any free text %removal-version%. %extra-info%. See %cr-link%
| | (Drupal.Semantics.FunctionTriggerError.TriggerErrorTextLayoutRelaxed)
391 | ERROR | [x] Expected 1 space after IF keyword; 0 found
| | (Drupal.ControlStructures.ControlSignature.SpaceAfterKeyword)
416 | ERROR | [ ] All functions defined in a module file must be prefixed with the module's name, found
| | "saml_sp_user_logout" but expected "saml_sp_drupal_login_saml_sp_user_logout"
| | (Drupal.NamingConventions.ValidFunctionName.InvalidPrefix)
488 | WARNING | [x] '@TODO: All of it.' should match the format '@todo Fix problem X here.'
| | (Drupal.Commenting.TodoComment.TodoFormat)
494 | ERROR | [ ] The trigger_error message 'Passing email as a string is deprecated in saml_sp:4.1.0 and will be
| | removed in saml_sp:5.0' does not match the relaxed standard format: %thing% is deprecated in
| | %deprecation-version% any free text %removal-version%. %extra-info%. See %cr-link%
| | (Drupal.Semantics.FunctionTriggerError.TriggerErrorTextLayoutRelaxed)
504 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters (Drupal.Files.LineLength.TooLong)
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------
FILE: modules/saml_sp_drupal_login/saml_sp_drupal_login.install
------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
26 | WARNING | [ ] Line exceeds 80 characters; contains 99 characters (Drupal.Files.LineLength.TooLong)
26 | ERROR | [x] Doc comment short description must start with a capital letter
| | (Drupal.Commenting.DocComment.ShortNotCapital)
26 | ERROR | [x] Doc comment short description must end with a full stop
| | (Drupal.Commenting.DocComment.ShortFullStop)
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------
FILE: modules/saml_sp_drupal_login/saml_sp_drupal_login.api.inc
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
12 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
| | (Drupal.Commenting.DocComment.ShortSingleLine)
------------------------------------------------------------------------------------------------------------------------
FILE: modules/saml_sp_drupal_login/src/Form/SamlSpDrupalLoginConfig.php
------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------------------------
29 | ERROR | [x] There must be exactly one blank line before the tags in a doc comment
| | (Drupal.Commenting.DocComment.SpacingBeforeTags)
32 | ERROR | [x] Expected 1 blank line before function; 2 found (Squiz.WhiteSpace.FunctionSpacing.Before)
34 | ERROR | [x] Expected 1 blank line after function; 2 found (Squiz.WhiteSpace.FunctionSpacing.After)
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------
FILE: modules/saml_sp_drupal_login/src/Controller/SamlSPDrupalLoginController.php
------------------------------------------------------------------------------------------------------------------------
FOUND 13 ERRORS AND 1 WARNING AFFECTING 10 LINES
------------------------------------------------------------------------------------------------------------------------
77 | ERROR | [x] Expected 1 blank line after function; 2 found (Squiz.WhiteSpace.FunctionSpacing.After)
81 | ERROR | [x] Doc comment short description must start with a capital letter
| | (Drupal.Commenting.DocComment.ShortNotCapital)
82 | ERROR | [ ] Doc comment short description must end with a full stop
| | (Drupal.Commenting.DocComment.ShortFullStop)
82 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate
| | paragraph (Drupal.Commenting.DocComment.ShortSingleLine)
84 | ERROR | [x] Additional blank lines found at end of doc comment (Drupal.Commenting.DocComment.SpacingAfter)
88 | ERROR | [x] Inline comments must start with a capital letter (Drupal.Commenting.InlineComment.NotCapital)
88 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing
| | parentheses (Drupal.Commenting.InlineComment.InvalidEndChar)
89 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 7
| | (Drupal.WhiteSpace.ScopeIndent.IncorrectExact)
92 | ERROR | [x] No space found before comment text; expected "// get the url for the idp" but found "//get the url
| | for the idp" (Drupal.Commenting.InlineComment.NoSpaceBefore)
92 | ERROR | [x] Inline comments must start with a capital letter (Drupal.Commenting.InlineComment.NotCapital)
92 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing
| | parentheses (Drupal.Commenting.InlineComment.InvalidEndChar)
97 | ERROR | [x] Inline comments must start with a capital letter (Drupal.Commenting.InlineComment.NotCapital)
98 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing
| | parentheses (Drupal.Commenting.InlineComment.InvalidEndChar)
118 | WARNING | [x] A comma should follow the last multiline array item. Found: ) (Drupal.Arrays.Array.CommaLastItem)
------------------------------------------------------------------------------------------------------------------------
see https://git.drupalcode.org/project/saml_sp/-/jobs/6337726
make a MR
Active
4.3
Code
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.