- Issue created by @paskainos
- π«π·France Grimreaper France π«π·
Which PHP version are you using?
Starting 1.1.0-alpha4, ui_skins requires PHP 8.3, but it seems that updating the .info.yml did not put the requirement into the automatically generated composer.json by drupal.org facade.
- π«π·France Grimreaper France π«π·
After discussion on infrastructure Slack channel, PHP requirement from .info.yml is not extracted, need to create a composer.json file.
Then indicate in previous release the problem.
- πΊπΈUnited States paskainos
Thank you, @grimreaper for your speedy response.
The site in question is running PHP 8.2 - mystery solved! Should've / could've anticipated that. My apologies for not including that crucial bit in (let alone testing for it prior to) my initial post.
After discussion on infrastructure Slack channel, PHP requirement from .info.yml is not extracted, need to create a composer.json file.
Then indicate in previous release the problem.
I'm not quite sure what that means. I guess my question is; do you need me to do anything further at this point?
- π«π·France Grimreaper France π«π·
Hello @paskainos,
No worries, I will finish this.
Should've / could've anticipated that.
1: I should have (and will) update release note to mention this new requirement
2: I didn't know that this .info.yml requirement was not taken automatically so I will also fix other contrib modules I maintain.
3: the .info.yml change only prevents installation, so for websites with the module already enabled it is not handledSo unfortunately, very little stuff you could have done no worries. Except looking at the whole diff but that's not something normally asked when doing updates ^^.
So it will be ok for next releases, composer will prevent the update, but not for 1.1.0-alpha4 so I will put a big warning message on release note.
-
grimreaper β
committed 4bb73e94 on 1.1.x
[#3545021] fix: Add composer.json By: paskainos By: grimreaper
-
grimreaper β
committed 4bb73e94 on 1.1.x
Now that this issue is closed, please review the contribution record.
As a contributor, attribute any organization helped you, or if you volunteered your own time.
Maintainers, please credit people who helped resolve this issue.