When rendering ads with the ad_content module, a PHP deprecation notice is triggered on PHP 8.1+:
Deprecated function: str_replace(): Passing null to parameter #2 ($replace) of type array|string is deprecated in Drupal\ad_content\Plugin\Ad\Bucket\AdContentBucket::postAdRender() (line 252 of /modules/contrib/ad/modules/ad_content/src/Plugin/Ad/Bucket/AdContentBucket.php)
This happens when $build['#ad_impression_id'] is missing or null, which results in str_replace() receiving an invalid argument.
ad and ad_content modules.str_replace(): Passing null to parameter #2 ($replace)...
Update AdContentBucket::postAdRender() to safely handle nulls by casting to string and defaulting to an empty string when the #ad_impression_id is not set. Example fix:
$search = (string) TrackerInterface::PLACEHOLDER_IMPRESSION; $replace = isset($build['#ad_impression_id']) ? (string) $build['#ad_impression_id'] : ''; $subject = (string) $markup; $output = str_replace($search, $replace, $subject); return $markup instanceof \Drupal\Component\Render\MarkupInterface ? \Drupal\Component\Render\Markup::create($output) : $output;
postAdRender() works without #ad_impression_id.Note: I will attach a patch to this issue, as I cannot currently provide a Merge Request on GitLab for this project.
None.
None (only internal implementation hardened).
None.
Active
11.0
ad module
@dobe please use MRs not patches.
@LR: Could you please have a look?
In general, we should perhaps find the cause of why the impression ID was null in the first place. @dobe right now, our solutions are equally correct, but let me take a look at what is actually happening under the hood there.