Enabling redirect_404 (or any module that decorates logger.factory) causes pages that render an Ad block to fatally error.
The constructor of \Drupal\ad\Track\TrackerFactory is hard‑typehinted to the concrete LoggerChannelFactory class, so dependency injection fails when the decorated service is not that concrete class.
Drupal best practice is to typehint the interface LoggerChannelFactoryInterface so decorated services are accepted.
\Drupal\ad\Plugin\Block\AdSlot::build() is invoked.logger.factory).Actual result
TypeError: Drupal\ad\Track\TrackerFactory::__construct(): Argument #2 ($loggerFactory) must be of type Drupal\Core\Logger\LoggerChannelFactory, Drupal\redirect_404\Render\Redirect404LogSuppressor given in Drupal\ad\Track\TrackerFactory->__construct() (modules/contrib/ad/src/Track/TrackerFactory.php:34)
Expected result
Pages render without fatal errors; the logger factory can be a decorated implementation.
Update TrackerFactory to typehint LoggerChannelFactoryInterface in the constructor (and docblock). No service IDs or definitions need to change. This aligns with Drupal DI guidelines and allows decorated services to be injected.
Alternative (also acceptable): inject @logger.channel.ad_content (a Psr\Log\LoggerInterface) directly and avoid calling get() on the factory.
Workaround
Apply a local patch that changes the constructor typehint to the interface, or temporarily disable modules that decorate logger.factory (not ideal).
LoggerChannelFactoryInterface and ensures TrackerFactory constructs.LoggerChannelFactory instead of the interface.None.
None. Internal constructor type uses the interface; no public API change.
None.
Active
11.0
ad module
@dobe please use MRs instead of patches. Your patch is correct, thank you for the fix! :)
@anybody as stated in the MR note. I cannot submit MR's because I cannot fork the repo in gitlab. When I try I get a CORS error. So when Drupal.org fixes that. I will definitely! Thank you!