- Issue created by @jenna.tollerson
- First commit to issue fork.
Attached is the fix addressing the use case involving a very large volume of feedback
- Merge request !17Issue #3543889: Fix allowed memory exhausted by introducing batch processing... → (Open) created by edmoreta
The previous patch was created on top of 8.x-2.7; attached is the 8.x-2.x version
- 🇪🇸Spain marcoscano Barcelona, Spain
I have reviewed the MR and the essence of the changes look good to me. There are a few coding standards violations but I'll leave to maintainers to decide whether that's a blocker or not.
Also, I feel the batch size of 50000 items could be made configurable, not sure if that could still be too much in certain low-memory environments. This could be done by either by exposing it directly in the module's settings form, or just with a setting in
admin_feedback.settingsand sites could override the value in settings.php to a different value as needed. But again, not a blocker, and could be done in a follow-up as well.