- Issue created by @wim leers
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
📌 [11.3.0-and-up] Remove hardcoded Image SDC from `\Drupal\experience_builder\Plugin\ExperienceBuilder\ComponentSource\SingleDirectoryComponent::componentMeetsRequirements` Postponed is supposed to remove the hard-coded checks, but more checks are needed.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
WTF, the snapshot tests still passed?!
Investigated, and turns out this is because Playwright defaults to saying "yep, this is valid", if the expectation is a subset of the actual! 🤯🫠
Looks like we need
/children: deep-equal
everywhere? 😅Out of scope here, opening new issue for it …
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
This is definitely on me — I should've spotted this in my reviews of 📌 Create an Image SDC that can be included by other SDCs Active !
Should be fully green now!
-
wim leers →
committed 66754b48 on 1.x
Issue #3543770 by wim leers, penyaskito: `noUi: true` SDCs do still show...
-
wim leers →
committed 66754b48 on 1.x