- Issue created by @pdureau
- 🇫🇷France pdureau Paris
Let's try a fresh new install, so with olivero as the only front theme.
Article full page
Setup:
- I create an article
- I activate Display builder from /admin/structure/types/manage/article/display
- I build the display suing the olivero
teaser
component: /admin/structure/types/manage/article/display/default/display-builder - I save
We pass through Olivero's
node.html.twig
Results:
- ❌ My comment field is never displayed, because of olivero's
node.html.twig
- ⚠️ I see the hardcoded metdata from olivero's
node.html.twig
. We can't consider this something to fix or something to keep.
Article teaser
We pass through Olivero's
node--teaser.html.twig
which a presenter template callingolivero:teaser
componentBefore activating display builder in /admin/structure/types/manage/article/display/teaser :
- ❌ The rendering of the teaser of broken maybe bcause of the current implementation of
EntityViewDisplayTrait::displayBuilderBuildMultiple()
After building /admin/structure/types/manage/article/display/teaser/display-builder
- ❌ The rendering of the teaser is still broken
- ❌ fixing it will not be enough because we are stuck with the rigid layout
conclusion
So, they are 2 things to fix in this issue:
- Don't break displays when display builder is not activated
- Skip wrapper template when display builder is activated
- Merge request !89Issue #3542881 by pdureau: Theme registry entry for Entity view display → (Merged) created by pdureau
- 🇫🇷France pdureau Paris
It will also be the opportunity to make Display Builder priority upon Layoutt Builder when both are activated, and maybe merge the 2 implementation of
::buildMultiple()
- 🇫🇷France pdureau Paris
Let's try a fresh new install, so with olivero as the only front theme.
Article full page
Setup:
- I create an article
- I activate Display builder from /admin/structure/types/manage/article/display
- I build the display using the olivero
teaser
component: /admin/structure/types/manage/article/display/default/display-builder - I save
✅ We don't pass through Olivero's
node.html.twig
anymoreResults:
- ❌ My comment field is still not displayed, but it is not because olivero's
node.html.twig
- ✅ I don't see the hardcoded metdata from olivero's
node.html.twig
.
Article teaser
Before activating display builder in /admin/structure/types/manage/article/display/teaser , we pass through Olivero's
node--teaser.html.twig
which a presenter template callingolivero:teaser
component:- ❌ The rendering of the teaser of broken is still broken
After building /admin/structure/types/manage/article/display/teaser/display-builder
- ✅ The rendering of the teaser is not broken anymore
- ✅ We are not stuck with the rigid layout
conclusion
So, they are 2 things to fix in this issue:
- ❌ Don't break displays when display builder is not activated
- ✅ Skip wrapper template when display builder is activated
And also:
- ✅ Make Display Builder priority upon Layout Builder when both are activated
- ✅ Merge the 2 implementations of ::buildMultiple()
-
mogtofu33 →
committed 78676b46 on 1.0.x authored by
pdureau →
#3542881 fix: theme registry entry for Entity view display
-
mogtofu33 →
committed 78676b46 on 1.0.x authored by
pdureau →