- Issue created by @tame4tex
- 🇨🇦Canada tame4tex
So it looks like this PHP warning is also thrown when adding an Entity Reference filter and setting the Reference method for the first time. I have updated the IS to reflect this.
- Merge request !13079Issue #3542769: Fix php warning in EntityReference::submitExtraOptionsForm → (Open) created by tame4tex
- 🇨🇦Canada tame4tex
This bug is preventing Functional Test from passing that set or change the Reference method in any Entity reference Views filter e.g. 🐛 Unable to get/set form_state values in SelectionPluginBase::validateConfigurationForm when called from EntityReference::validateExtraOptionsForm Active .
- First commit to issue fork.
- 🇺🇸United States smustgrave
Had to rebase for the test-only job to run https://git.drupalcode.org/issue/drupal-3542769/-/jobs/6399689
1) Drupal\Tests\views_ui\Functional\FilterEntityReferenceWebTest::testFilterUi Exception: Warning: Undefined array key "reference_views" Drupal\views\Plugin\views\filter\EntityReference->submitExtraOptionsForm()() (Line: 367) /builds/issue/drupal-3542769/core/lib/Drupal/Core/Test/HttpClientMiddleware/TestHttpClientMiddleware.php:55 /builds/issue/drupal-3542769/vendor/guzzlehttp/promises/src/Promise.php:209 /builds/issue/drupal-3542769/vendor/guzzlehttp/promises/src/Promise.php:158 /builds/issue/drupal-3542769/vendor/guzzlehttp/promises/src/TaskQueue.php:52 /builds/issue/drupal-3542769/vendor/guzzlehttp/promises/src/Promise.php:251 /builds/issue/drupal-3542769/vendor/guzzlehttp/promises/src/Promise.php:227 /builds/issue/drupal-3542769/vendor/guzzlehttp/promises/src/Promise.php:272 /builds/issue/drupal-3542769/vendor/guzzlehttp/promises/src/Promise.php:229 /builds/issue/drupal-3542769/vendor/guzzlehttp/promises/src/Promise.php:69 /builds/issue/drupal-3542769/vendor/guzzlehttp/guzzle/src/Client.php:189 /builds/issue/drupal-3542769/core/tests/Drupal/Tests/DrupalTestBrowser.php:139 /builds/issue/drupal-3542769/vendor/symfony/browser-kit/AbstractBrowser.php:378 /builds/issue/drupal-3542769/vendor/symfony/browser-kit/AbstractBrowser.php:298 /builds/issue/drupal-3542769/vendor/behat/mink-browserkit-driver/src/BrowserKitDriver.php:718 /builds/issue/drupal-3542769/vendor/behat/mink-browserkit-driver/src/BrowserKitDriver.php:494 /builds/issue/drupal-3542769/vendor/behat/mink/src/Element/NodeElement.php:176 /builds/issue/drupal-3542769/vendor/behat/mink/src/Element/NodeElement.php:186 /builds/issue/drupal-3542769/core/tests/Drupal/Tests/UiHelperTrait.php:112 /builds/issue/drupal-3542769/core/modules/views_ui/tests/src/Functional/FilterEntityReferenceWebTest.php:108 ERRORS!
Which shows the coverage for the change being added.
Trying to replicate following the steps, not using the contrib module though, I believe I'm able to see it. The change to submitExtraOptionsForm makes sense to me.
LGTM