Contrib.social

Remove unneeded returns in multiple methods

Open on Drupal.org →
Created on 22 August 2025, 25 days ago

Various methods have a return even though the FormBase class does not have them. These should be removed to avoid confusion and unintended behavior.

📌 Task
Status

Active

Version

1.0

Component

Code

Created by

🇩🇪Germany atropoides Hamburg

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @atropoides
  • Merge request !17#3542585 - Remove unneeded returns from methods → (Open) created by atropoides
  • Comment 25 days ago →
    🇩🇪Germany atropoides Hamburg
  • Pipeline finished with Success
    25 days ago
    Total: 157s
    #579086
  • First commit to issue fork.
  • Comment 25 days ago →
    🇩🇪Germany Harlor Berlin

    1. According to EntityFormInterface the save() method has a return value of type int. (I brought that one back)
    2. The return type of validateForm() and submitForm() is not specified on the FormInterface - so even though it doesn't seem to be used anywhere I'm wondering if it really hurts if we pass through the return value.

    Did your IDE or some tool notify you about potential issues?

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024