- Issue created by @michaellander
-
michaellander →
committed a3a579dc on 1.0.x
Resolve #3542472 "Remove context definitions"
-
michaellander →
committed a3a579dc on 1.0.x
Right now we are using input_definitions that auto generate context_definitions. This was done for two reasons, to preserve using the ContextAwarePluginInterface that is common in core(that we are no longer using) and to allow creating sub-tools in the UI that preset and lock some inputs. This meant that on calls to access and execute, we'd grab values from context and configuration and set the values into unlocked input_definitions, validate and return all the values. This does create some inconsistencies where in plugins you are defining input_definitions, but when interacting with plugins you are actually calling setContextValue()..
Remove context_definitions completely and just use input_definitions, with setInputValue and getInputDefinitions($include_locked = FALSE);. Most external calls will never need to use getInputDefinitions(TRUE), which will just be more straightforward and intuitive, which is ultimately the goal of this module. If we are no longer using the ContextAwarePluginInterface, then there's no reason to preserve that behavior.
Active
Code
Resolve #3542472 "Remove context definitions"