- Issue created by @GΓ‘bor Hojtsy
- ππΊHungary GΓ‘bor Hojtsy Hungary
@mglaman suggests this is caused by pathato being enabled, and indeed, I have pathauto in xb-demo. I don't know if @pameela has pathauto, but I assume she was testing with Drupal CMS 2.x which has it.
When pathauto is installed, this hook is useful to work around this per @mglaman:
#[Hook('xb_page_presave')] public function ensurePathautoSkipped(Page $page): void { $page->get('path')->first()->set('pathauto', PathautoState::SKIP); }
- ππΊHungary GΓ‘bor Hojtsy Hungary
Attached patch for composer patching needs (eg. in xb-demo).
I think some form of this needs to go to XB to make it viable on a site. Not the fix as-is, although it is nicely compartmentalised outside of the normal XB flow to show it is a workaround. Will leave it to maintainers to triage though :)
- πΊπΈUnited States phenaproxima Massachusetts
Escalating this. Drupal CMS needs this, because without it, we cannot ship site templates that work in a consistent way. We can patch XB for now, but this will need to get fixed before Drupal CMS can release an XB-ready version.
- ππΊHungary GΓ‘bor Hojtsy Hungary
Discussing this with Lauri he indicated
I don't think [this] is a must have. You could just disable pathauto for XB pages and rely on the XB built in path generation
Is that possible to configure in Drupal CMS?
- ππΊHungary GΓ‘bor Hojtsy Hungary
I checked how can pathauto be disabled on xb pages in xb-demo. However, it looks from pathauto's simple config that only nodes are enabled for patterns:
enabled_entity_types: - user punctuation: hyphen: 1 verbose: false separator: '-' max_length: 100 max_component_length: 100 transliterate: true reduce_ascii: false case: true ignore_words: 'a, an, as, at, before, but, by, for, from, is, in, into, like, of, off, on, onto, per, since, than, the, this, that, to, up, via, with' update_action: 2 safe_tokens: - alias - path - join-path - login-url - url - url-brief
Also this is the only thing that has a pathauto pattern entity:
However when I went to the Pathauto settings page, XB pages seem to be enabled for pattens but no way to disable them:
Where is this enforcement coming from?
- πΊπΈUnited States darren oh Lakeland, Florida
darren oh β made their first commit to this issueβs fork.
- ππΊHungary GΓ‘bor Hojtsy Hungary
Updated patch with Darren's fix (thanks!).
- ππΊHungary GΓ‘bor Hojtsy Hungary
Duh that was for XB :D Here is the one for Canvas. Sorry for the noise.
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
This seems to be handling a subset of π XB pages doesn't respect Pathauto widget Active .
How can there be a bug in Canvas if we've never worked on
pathauto
compatibility? π β changing issue categoryThe MR looks great (hence approved)! π
However, but CI is not passing. AFAICT only because
pathauto
needs to become a dev dependency first π Happy to merge when green π - πΊπΈUnited States phenaproxima Massachusetts
This is no longer a Drupal CMS critical, because we are working around it in our helper module. It would be great to fix it before stable, but if that doesn't happen, Drupal CMS will not be broken by it. Untagging.
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
#16 is not yet addressed:
pathauto
needs to become a dev dependency for it to pass CI.