- Issue created by @max-ar
- First commit to issue fork.
- 🇮🇳India arunsahijpal
Hi @max-ar,
I think removing the$idis not a good choice as it is used in other places also so I made it explicitly nullable, pls check.
Attached is a fix for the php 8.4 deprecation notice in;
PHP Deprecated: Drupal\admin_feedback\Form\AdminFeedbackDeleteForm::buildForm(): Implicitly marking parameter $id as nullable is deprecated, the explicit nullable type must be used instead in admin_feedback/src/Form/AdminFeedbackDeleteForm.php on line 81
Deprecated: Drupal\admin_feedback\Form\AdminFeedbackDeleteForm::buildForm(): Implicitly marking parameter $id as nullable is deprecated, the explicit nullable type must be used instead in /admin_feedback/src/Form/AdminFeedbackDeleteForm.php on line 81
I have removed the `$id` var from the function, it seems to do nothing, and no other code in the module calls it using `$id`.
Active
2.7
Code
Hi @max-ar,
I think removing the $id is not a good choice as it is used in other places also so I made it explicitly nullable, pls check.