- Issue created by @phenaproxima
- First commit to issue fork.
- πΊπΈUnited States phenaproxima Massachusetts
As part of this, we should remove CSS classes that target specific webforms by their config ID, such as
webform--newsletter-signup
. Webforms have the ability to be assigned arbitrary CSS classes, so instead let's just replace that selector with something likemercury-footer--webform
, and then rely on site templates to assign that class to any webforms that they might want to place in the footer. - πΊπΈUnited States galactus86
Since we will now have a webform CSS library, how do we want to attach, sounds like we should avoid attaching to a
.twig
file. Preprocessor? - πΊπΈUnited States phenaproxima Massachusetts
I think that'd be fine. It's okay to attach it in a Twig file, just not for a specific webform (identified by ID). Putting it in webform.html.twig would be okay.
- πΊπΈUnited States galactus86
Ready to merge, won't be shocked if we have to take another pass at tweaks based on real behavior on Drupal side.
-
galactus86 β
committed 53d99e94 on 1.x
Issue #3542111: Webforms are completely unstyled
-
galactus86 β
committed 53d99e94 on 1.x