- Issue created by @entropea
- 🇬🇧United Kingdom entropea
https://git.drupalcode.org/project/civicrm_entity/-/merge_requests/9 submitted for review, no doubt lots of improvements can be made!
- 🇺🇸United States markusa
Do you mind making a PR against the 4.0.x branch on github?
https://github.com/eileenmcnaughton/civicrm_entity/
We have tests that run there, legacy of pre-Drupal-gitlab, and hadn't had the motivation to move here yet.
For feedback for this contribution, this is great!! Thank you.
I couple of things .. can you add PHP Attributes for the Plugins ?
We are trying to make new code as forward looking as possible.
Its a one line addition, example here: https://github.com/eileenmcnaughton/civicrm_entity/blob/4.0.x/src/Plugin...I don't see any other issues, but I'll test when there's a PR. Thanks again!
- 🇬🇧United Kingdom entropea
You're welcome, thanks for the positive feedback!
PR has been submitted with added the PHP attrib :) https://github.com/eileenmcnaughton/civicrm_entity/pull/533
- 🇺🇸United States markusa
Ok this feature is reviewed and merged, included in 4.0.1 just released
Now that this issue is closed, please review the contribution record.
As a contributor, attribute any organization helped you, or if you volunteered your own time.
Maintainers, please credit people who helped resolve this issue.